Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511235

Summary:	Some linting rules should not be disabled having an eslintrc* file
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	curtis.windatt.public, steve_northover
Version:	13.0
Target Milestone:	14.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2017-01-27 14:40:28 EST

If you have a project that has an eslintrc file in it, we properly use that file to override the workspace linting settings (GOOD). The problem comes in that unless you include our custom rules like unknown-require or check-tern-plugin, you will not be alerted to improper project configurations.

For an example, grab the brackets code (https://github.com/adobe/brackets) and open the file CommandManager.js. If you try to use open decl to jump to a function in the only required file (EventManager) you are greeted with a "cannot find declaration" message. The reason for this is that the commonjs plugin is not running in Tern (see bug 496739), and you are not alerted to that fact because their eslintrc file does not have our lint rules in it (which turns them off).

Comment 1 Michael Rennie

2017-01-27 15:16:24 EST

Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3319095a454cffdcd9a2a809fd73da97f56ea595

There are three rules we use to ensure proper project configuration:

unknown-require
check-tern-plugin
missing-requirejs