Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511228

Summary:	[Webkit2] Ensure proper settings are used for webkit2.
Product:	[Eclipse Project] Platform	Reporter:	Leo Ufimtsev <lufimtse>
Component:	SWT	Assignee:	Leo Ufimtsev <lufimtse>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov
Version:	4.7
Target Milestone:	4.7 M7
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/92731 https://git.eclipse.org/r/92796 https://git.eclipse.org/r/92808 https://git.eclipse.org/r/92810 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b45856aec079b92fd7b33ea19df0de052c43d9d6 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4899004f5a22a728a15653110e2a046f9adb2d10 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=08f0fe88dce9b824dd981b8cac6e46f48fdccbe0 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0fd3b423892bd65e6598fec0a10269ffc0249fcf
Whiteboard:
Bug Depends on:
Bug Blocks:	441568

Description Leo Ufimtsev

2017-01-27 12:54:06 EST

I observed in Webkit:
OS.g_object_set (settings, WebKitGTK.enable_scripts, jsEnabled ? 1 : 0, 0);

WebKitGTK.enable_scripts = ascii ("enable-scripts");
https://webkitgtk.org/reference/webkitgtk/stable/WebKitWebSettings.html#WebKitWebSettings--enable-scripts

But in webkit2 this setting doesn't exist. It should instead be setting "enable-javascript", which is set via:
webkit_settings_set_enable_javascript (....)
https://webkitgtk.org/reference/webkit2gtk/stable/WebKitSettings.html#webkit-settings-set-enable-javascript


I need to go through the list of all properties in WebKitGTK and make sure that for webkit2, the correct property is used.

Comment 1 Eclipse Genie

2017-03-09 15:23:48 EST

New Gerrit change created: https://git.eclipse.org/r/92731

Comment 2 Eclipse Genie

2017-03-10 11:56:04 EST

New Gerrit change created: https://git.eclipse.org/r/92796

Comment 3 Eclipse Genie

2017-03-10 14:57:40 EST

New Gerrit change created: https://git.eclipse.org/r/92808

Comment 4 Eclipse Genie

2017-03-10 15:14:42 EST

New Gerrit change created: https://git.eclipse.org/r/92810

Comment 5 Eclipse Genie

2017-03-10 16:00:09 EST

New Gerrit change created: https://git.eclipse.org/r/92815

Comment 6 Eclipse Genie

2017-03-10 16:00:33 EST

Gerrit change https://git.eclipse.org/r/92815 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=064b52752d54a4d72a9082bc2e898063bd716a34

Comment 7 Leo Ufimtsev

2017-03-10 16:03:28 EST

> New Gerrit change created: https://git.eclipse.org/r/92815

(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/92815 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=064b52752d54a4d72a9082bc2e898063bd716a34

Ignore, wrongly linked.(In reply to Eclipse Genie from comment #5)

Comment 8 Eclipse Genie

2017-03-11 03:46:05 EST

Gerrit change https://git.eclipse.org/r/92731 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b45856aec079b92fd7b33ea19df0de052c43d9d6

Comment 9 Eclipse Genie

2017-03-11 03:53:20 EST

Gerrit change https://git.eclipse.org/r/92796 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4899004f5a22a728a15653110e2a046f9adb2d10

Comment 10 Eclipse Genie

2017-03-11 04:03:28 EST

Gerrit change https://git.eclipse.org/r/92808 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=08f0fe88dce9b824dd981b8cac6e46f48fdccbe0

Comment 11 Eclipse Genie

2017-03-11 04:15:25 EST

Gerrit change https://git.eclipse.org/r/92810 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0fd3b423892bd65e6598fec0a10269ffc0249fcf

Comment 12 Alexander Kurtakov

2017-03-11 04:16:15 EST

All patches are in. Is there any more work here Leo or it should be resolved?

Comment 13 Leo Ufimtsev

2017-03-13 10:01:35 EDT

(In reply to Alexander Kurtakov from comment #12)
> All patches are in. Is there any more work here Leo or it should be resolved?

Thank you for the quick patch reviews.

I haven't yet checked if all properties are ported yet. So let's keep open until I finish going through the list.

Comment 14 Leo Ufimtsev

2017-03-21 16:55:21 EDT

All settings were ported.