Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511019

Summary: Empty semantic resource ignored by the DAnalysisSessionImpl
Product: [Modeling] Sirius Reporter: Hugo Marchadour <hugo.marchadour>
Component: CoreAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact: Laurent Redor <laurent.redor>
Severity: normal    
Priority: P3 CC: laurent.redor, pierre-charles.david
Version: 4.1.1Keywords: triaged
Target Milestone: 5.0.0M7   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/95358
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6054da008604a0cbeac2dd479863a77f4f74781b
Whiteboard: backport

Description Hugo Marchadour CLA 2017-01-25 05:58:13 EST 
The doAddSemanticResource test if the given newResource is not empty (DAnalysisSessionImpl L618). There is no reason to black list an empty resource (It's empty state can evolve).
Comment 1 Eclipse Genie CLA 2017-04-20 06:54:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/95358
Comment 2 Pierre-Charles David CLA 2017-04-20 07:31:25 EDT 
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/95358

Quick draft to see what the Gerrit tests say.
Comment 4 Pierre-Charles David CLA 2017-05-02 05:32:36 EDT 
I've pushed the "obivous" fix, as the gerrit tests were OK and Cédric give it +2. Waiting for the full tests to run for a while before we close this (if no regression is identified).
Comment 5 Pierre-Charles David CLA 2017-05-04 11:28:11 EDT 
Full test suites have run several times since this was merge with no visible regression. Closing.
Comment 6 Laurent Redor CLA 2017-05-19 10:41:36 EDT 
No real validation as it is not possible (except by programmation to have an empty resource).
Comment 7 Pierre-Charles David CLA 2017-06-29 03:31:46 EDT 
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.