Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510808

Summary: link categories contributed by plugin not working in Orion 13.0
Product: [ECD] Orion Reporter: Rafael Chaves <eclipse>
Component: ClientAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: major    
Priority: P3 CC: emoffatt, Silenio_Quarti, steve_northover
Version: 13.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
contribution to orion.page.link.category
none
contribution to orion.page.link.related none

Description Rafael Chaves CLA 2017-01-21 16:11:12 EST
Apparently, link categories contributed by plugins are not working in Orion 13.0.

These contributions used to work fine since Orion 7.0 up to 12.0, but no longer are shown in the UI in 13.0:

provider.registerService("orion.page.link.category", null, {
        nameKey: "Cloudfier Documentation",
        id: "cloudfier-documentation",
        imageDataURI: "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gwIEDYoRCuI7gAAABl0RVh0Q29tbWVudABDcmVhdGVkIHdpdGggR0lNUFeBDhcAAAQbSURBVDgRARAE7/sAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD///82AAAALgAAAAAAAADVAQEBxwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////AAAAAAD///9a////9v/////////r////6f/////////5////YQAAAAD///8AAAAAAAAAAAAAAAAAAAAAAAAAAAAA////lP////////99////AwAAAAAAAAAA////Af///3f/////////nQAAAAAAAAAAAAAAAAAAAAAAAAAAAP///1r/////////MgAAAAD///8q////ov///6P///8xAAAAAP///yv/////////ZAAAAAAAAAAAAAAAAAAAAAAA////9v///30AAAAA////B//////////L////x/////////8ZAAAAAP///3P////9AAAAAAAAAAAAAAAAAP///zb/////////AwAAAAD///9A////4wAAAAAAAAAA/////////10AAAAAAAAAAP////////8/AAAAAAAAAAAA////ZP///+sAAAAAAAAAAAAAAAAAAAAAAAAAAP///43/////////EgAAAAAAAAAA////4P///20AAAAAAgAAAAAAAAAAAAAA/gAAAAAAAAAAAAAAAAAAAAD///9pAAAAcgAAADcBAQHuAAAAAAAAAAAAAAD/AAAAAAAAAAACAAAAAAAAANUAAAAW////AQAAAAAAAAAAAAAAAAAAAPkAAABzAQEBygAAAAAAAAAAAAAAAAAAACAAAADVAAAAAAIAAAAAAQEBxwAAAPoAAAB2AAAAAAAAAAAAAAAAAAAADwAAACUAAAAAAAAAAAAAAAD///9uAAAAAAEBAb4AAAAAAAAAAAAAAAAA////Yf////////8rAAAAAAAAAAD///+L////tgAAAAAAAAAA////Jf////////9qAAAAAAAAAAAAAAAAAAAAAAAAAAAA////nf////////9zAAAAAAAAAAAAAAAAAAAAAP///27/////////pgAAAAAAAAAAAAAAAAAAAAAAAAAAAP///wAAAAAA////ZP////3/////////4P///9///////////////2oAAAAA////AAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///z8AAAAuAAAAAAAAANUBAQG+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP66Nf1SIjHTAAAAAElFTkSuQmCC",
        order: 1000
});

provider.registerService("orion.page.link.category", null, {
        nameKey: "Cloudfier Examples",
        id: "cloudfier-examples",
        imageDataURI: "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gwIEDEIMAQ+4QAAABl0RVh0Q29tbWVudABDcmVhdGVkIHdpdGggR0lNUFeBDhcAABArSURBVFgJASAQ3+8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////3////78AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD///8F////EAAAAAAAAAAAAAAAAAAAAAAAAAAA/////////+gAAAAAAAAAAAAAAAAAAAAAAAAAAP///yEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD////8/////////wkAAAAAAAAAAAAAAAAAAAAA/////////+gAAAAAAAAAAAAAAAAAAAAA////DP/////////HAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADIAAAAAAAAAIcAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA1gAAAAAAAACmAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////+v////////8hAAAAAAAAAAAAAAAA/////////+gAAAAAAAAAAAAAAAD///8p//////////7///8EAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////iP/////////JAAAAAAAAAAAAAAAA/////////+MAAAAAAAAAAP///wP//////////////y0AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////Av///wMAAAAAAAAAAAAAAAAAAAAAAAAAAP///+r/////////QQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///17/////////6gAAAAAAAAAAAAAAAAAAAAAAAAAA////A////wIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////f////z///9aAAAAAAAAAAAAAAAAAAAAAP///0n///9+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///wP///+j////BwAAAAAAAAAAAAAAAAAAAAD///+E/////////7oAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////qv//////////////8v///xsAAAAAAAAAAAAAAAAAAAAAAAAAAP///7D////2////+f////n////0////jAAAAAAAAAAAAAAAAAAAAAAAAAAA////Rf////X//////////////38AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///x/////x///////////////ZAAAAAAAAAAD///9k/////v////////////////////////////////////T///8eAAAAAAAAAAD////d///////////////O////EwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////Q/////////9MAAAAAP///1f/////////////////////////////////////////////////////////CwAAAAD///+m/////f///zMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///wYBAQH6AAAAAP////cAAAAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA8gAAABAAAAAAAQEB/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEBAfoAAAAA////dAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADgAAABUBAQH/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAawAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOkAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAxgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////DwAAAPAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAYBAQH7AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQEB8QAAAMsAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAfwEBAfsAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///wkAAAD2AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD8AQEBBQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEBAfcAAADJAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACTAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD///9A//////////////////////////////////////////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////8////////////////////////////////////+4AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA0AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA1QAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA////Hf///////////////////////////////QAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQEB4////3wAAAAkAAAAAAAAAAAAAAAAAAAA0QAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAANcAAADuAAAAAAAAAAAAAAAAAAAA4AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP///8j////w////8P////D////x////vgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALoAAADVAAAAAAAAAAAAAAAAAAAA3gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALYAAAA/AAAAAQAAAAAAAAD8AAAAvgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD///+I/////P////f///9pAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADUWkgorka3bgAAAABJRU5ErkJggg==",
        order: 1001
});

provider.registerServiceProvider("orion.page.link.related", {}, {
    id: "orion.cloudfier.content.examples",
    tooltip: "Check out existing projects from the Cloudfier example repository.",
    name: "Get Cloudfier examples",
    category: "cloudfier-examples",
    uriTemplate: "{+OrionHome}/git/git-repository.html#,cloneGitRepository=https://github.com/abstratt/cloudfier-examples.git"
});

provider.registerServiceProvider("orion.page.link.related", {}, {
    id: "orion.cloudfier.content.documentation",
    tooltip: "Learn how to write Cloudfier programs.",
    name: "Cloudfier documentation",
    category: "cloudfier-documentation",
    uriTemplate: "http://doc.cloudfier.com/"
});
Comment 1 Rafael Chaves CLA 2017-01-21 16:15:16 EST
Not sure it is a meaningful signal, but the feature that allows one to browse the services contributed by a plugin, shows the name of the service at the bottom of all contributions made by plug-in, except for those to the orion.page.link.category service.
Comment 2 Rafael Chaves CLA 2017-01-21 16:16:58 EST
Created attachment 266394 [details]
contribution to orion.page.link.category
Comment 3 Rafael Chaves CLA 2017-01-21 16:17:47 EST
Created attachment 266395 [details]
contribution to orion.page.link.related
Comment 4 Rafael Chaves CLA 2017-01-21 19:35:50 EST
Hmm, just noticed my category declares a 'nameKey' slot, whereas Git's declares a 'name' slot. Maybe the name of the expected slot changed in 13.0? 

This older version of the corresponding documentation wiki page mentions nameKey: 

https://wiki.eclipse.org/index.php?title=Orion/Documentation/Developer_Guide/Plugging_into_Orion_pages&oldid=358202#orion.page.link.category

but now it is gone.

I will change my plugin code accordingly. You guys decide whether supporing the legacy slot is worthwhile w.r.t. backwards compatibility.
Comment 5 Rafael Chaves CLA 2017-01-21 21:18:00 EST
Oh man, this is embarrassing. Turns out the category icons have been there the whole time, I just couldn't see them because I guess they are white with a transparent background, and Orion's navigator bar in 13.0 is now white...

You would think that when selected they would show, but both links take the user to another non-Orion page.

Not sure about two things: 

1) how to define a category image with a transparent background that will continue to show no matter the background color the navigator in Orion is using?

2) why is the contribution showing without the service id (see screenshots).
Comment 6 Steve Northover CLA 2017-03-29 17:11:43 EDT
Sound like it was a "white on white" problem.  Sorry about that.  Not sure what action we can take.