Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510802

Summary: Workspace API has failing tests due to workspace name change
Product: [ECD] Orion Reporter: Remy Suen <remy.suen>
Component: NodeAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: 13.0   
Target Milestone: 14.0   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/89279
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=53286d40cb8695035b2483b29a927b21d65c14b2
Whiteboard:

Description Remy Suen CLA 2017-01-21 07:47:19 EST
'Orionode Workspace' stopped being the workspace name back in June. However, the tests were not updated to reflect this change.

https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f42c6112801522c0478cd54f260faabbe2243298

Please note that I have removed the other tests to take them out of the picture which explains why they're not showing up in the test output below.

-------------------------

> npm test

> Orion@0.1.0 test orion.client\modules\orionode
> mocha --reporter spec



  Workspace API
    workspace
      1) list workspaces
      √ create workspace should fail
      2) get workspace metadata
      √ change workspace metadata should fail (162ms)
      √ delete workspace should fail
    project
      √ rename a project should succeed (43ms)


  4 passing (2s)
  2 failing

  1) Workspace API workspace list workspaces:

      Uncaught AssertionError: '.test_workspace' == 'Orionode Workspace'
      + expected - actual

      -.test_workspace
      +Orionode Workspace

      at Test.<anonymous> (orion.client\modules\orionode\test\workspace.js:86:12)
      at Test.assert (orion.client\modules\orionode\node_modules\supertest\lib\test.js:156:6)
      at Server.assert (orion.client\modules\orionode\node_modules\supertest\lib\test.js:127:12)
      at emitCloseNT (net.js:1521:8)

  2) Workspace API workspace get workspace metadata:

      Uncaught AssertionError: '.test_workspace' == 'Orionode Workspace'
      + expected - actual

      -.test_workspace
      +Orionode Workspace

      at Test.<anonymous> (orion.client\modules\orionode\test\workspace.js:104:13)
      at Test.assert (orion.client\modules\orionode\node_modules\supertest\lib\test.js:156:6)
      at Server.assert (orion.client\modules\orionode\node_modules\supertest\lib\test.js:127:12)
      at emitCloseNT (net.js:1521:8)
Comment 1 Eclipse Genie CLA 2017-01-21 07:50:17 EST
New Gerrit change created: https://git.eclipse.org/r/89279
Comment 3 Michael Rennie CLA 2017-01-23 10:59:14 EST
Merged, thanks Remy!