Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510800

Summary: Test for retrieving commits with a revision is failing
Product: [ECD] Orion Reporter: Remy Suen <remy.suen>
Component: GitAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: 13.0   
Target Milestone: 14.0   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/89277
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e1eb818ab76a58936846a04b4e122cb3d487933c
Whiteboard:

Description Remy Suen CLA 2017-01-21 05:37:01 EST
This test has been broken since June 2016 by the fix to bug 495809.

Note that I'm also getting various other test failures but I haven't yet looked at each of them in detail.

-----------------

  git
    Use case 1
      Creates a new directory and init repository
        √ GET clone (initializes a git repo) (63ms)
        √ Check the directory was made
        √ Check nodegit that the repo was initialized
      Creating and adding a new file
        √ PUT index (staging a file)
        √ GET status (check status for git repo)
      Committing an added file
        √ POST commit (committing all files in the index)
        1) GET commit (listing commits revision)
        √ Check nodegit for commits
      Adding a remote
        √ POST remote (adding a new remote)
      Get list of remotes
        √ GET remote (getting the list of remotes)
        √ Check nodegit for list of remotes
      Fetching a remote
        √ POST remote (fetching changes from a remote) (2556ms)
      Deleting a remote
        √ DELETE remote (removing a remote)
        √ Check nodegit for deleted remote
      Add a new remote and push to it
        √ POST remote (adding a new remote)
        √ POST remote (pushing to a new remote) (2750ms)
      Removing a repository
        2) DELETE clone (delete a repository)
        √ Check nodegit for deleted repo

  1) git Use case 1 Committing an added file GET commit (listing commits revision):
     Uncaught Error: expected 200 "OK", got 202 "Accepted"
      at Test._assertStatus (orion.client\node\modules\orionode\node_modules\supertest\lib\test.js:232:12)
      at Test._assertFunction (orion.client\node\modules\orionode\node_modules\supertest\lib\test.js:247:11)
      at Test.assert (orion.client\node\modules\orionode\node_modules\supertest\lib\test.js:148:18)
      at Server.assert (orion.client\node\modules\orionode\node_modules\supertest\lib\test.js:127:12)
      at emitCloseNT (net.js:1521:8)
Comment 1 Eclipse Genie CLA 2017-01-21 05:41:15 EST
New Gerrit change created: https://git.eclipse.org/r/89277
Comment 3 Michael Rennie CLA 2017-01-23 11:56:09 EST
Merged the first fix. 

Are you planning to submit fixes for the other failures in the bug? Or are you considering this one fixed?
Comment 4 Remy Suen CLA 2017-01-23 15:34:38 EST
(In reply to Michael Rennie from comment #3)
> Are you planning to submit fixes for the other failures in the bug? Or are
> you considering this one fixed?

I'm going to open separate bugs for those other failures when I get to the bottom of them, Michael.

Bug 500579 is the cause of one of the failures anyway.