Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510742

Summary:	Shell page spams console log with TypeError
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Client	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	13.0
Target Milestone:	14.0
Hardware:	PC
OS:	Windows NT
See Also:	https://git.eclipse.org/r/89183 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3a0b29c14c21315109445eecaab05631680d08c0
Whiteboard:

Description Remy Suen

2017-01-20 05:31:18 EST

1. Open the 'Shell' page.
2. Type 'cd'.
3. Check your browser console to see a slew of TypeErrors.

This was caused by a small typo in the fix for bug 496200.

TypeError: Date.now(...).getTime is not a function
    at NewType.lookup (Shell.js:195)
    at selection.js:173
    at effort (promise.js:48)
    at resolved (promise.js:113)
    at Object.then (promise.js:30)
    at Object.then (promise.js:119)
    at resolve (selection.js:171)
    at NewType.SelectionType.getLookup (selection.js:138)
    at NewType.<anonymous> (selection.js:325)
    at new Conversion (types.js:129)

Comment 1 Eclipse Genie

2017-01-20 05:36:00 EST

New Gerrit change created: https://git.eclipse.org/r/89183

Comment 2 Eclipse Genie

2017-01-20 10:57:54 EST

Gerrit change https://git.eclipse.org/r/89183 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3a0b29c14c21315109445eecaab05631680d08c0

Comment 3 Michael Rennie

2017-01-20 11:08:38 EST

Merged, thanks Remy!