Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510711

Summary:	SetPropertyValueOperation should be content-relevant per default and a setter, setContentRelevant(boolean), should be provided.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.1.0
Target Milestone:	5.0.0 (Oxygen) M6
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2017-01-19 13:26:34 EST

Currently, SetPropertyValueOperation is content-irrelevant per default and does not provide a means to change its content-relevancy. However, property changes are content-relevant in nature (MVC Logo example: shape's fill, curve's routing-style, etc.), therefore, the SetPropertyValueOperation should be content-relevant per default. However, not all properties need to be persisted. Therefore, SetPropertyValueOperation should provide a setter for its content-relevancy, so that the user can set it individually for all properties by providing a custom UndoablePropertySheetEntry.

Comment 1 Matthias Wienand

2017-02-20 08:56:03 EST

I changed the default content-relevancy of SetPropertyValueOperation to true and added a field and a setter method so that the content-relevancy can be changed after the operation was created. Hence, the UndoablePropertySheetEntry can still be used to construct the operation, and it can be subclassed to mark some operations content-irrelevant. The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 M6.