Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510693

Summary: Zoom tool in palette do not work
Product: [Modeling] Sirius Reporter: Jessy Mallet <jessy.mallet>
Component: DiagramAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: maxime.porhel, pierre-charles.david
Version: 4.1.1Keywords: triaged
Target Milestone: 4.1.3   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/89199
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e0922399c5a66d902bbb26902cec690d5d68aa54
https://git.eclipse.org/r/89332
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f4c529404d2d3f3f6c850179c9a95ab4e07c9d87
Whiteboard: regression
Bug Depends on:    
Bug Blocks: 510760    
Attachments:
Description Flags
Example of project with diagram
none
steps reproduced none

Description Jessy Mallet CLA 2017-01-19 09:50:16 EST
Created attachment 266360 [details]
Example of project with diagram

In the palette, when the zoom out (-) button is active, clicking anywhere on the diagram does not decrement zoom level.
Moreover, when the zoom out button is active, selection on diagram increment zoom level instead of decrement.

Step to reproduce :
1- Open a diagram 
(for example import zoomBugProject in your workspace and open P1 class diagram)
2- Activate zoom out button
3- click anywhere on the diagram
Comment 1 Jessy Mallet CLA 2017-01-19 09:51:14 EST
Created attachment 266361 [details]
steps reproduced
Comment 2 Pierre-Charles David CLA 2017-01-20 04:43:07 EST
Confirmed. This is a regression since Sirius 4.0.0 (where this works), and which is already present in 4.1.0.

The regression was caused by commit 537883625c0e15b92b4e540f2df708ee72bb71ca but bugzilla #498494. Reverting that patch fixes the issue. More analysis is needed to isolate the offending part and fix the issue without losing the feature introduced by #498494.
Comment 3 Eclipse Genie CLA 2017-01-20 08:06:46 EST
New Gerrit change created: https://git.eclipse.org/r/89199
Comment 5 Eclipse Genie CLA 2017-01-20 08:41:12 EST
New Gerrit change created: https://git.eclipse.org/r/89205
Comment 6 Maxime Porhel CLA 2017-01-20 08:46:26 EST
Corrected in 4.1.3 with commit e0922399c5a66d902bbb26902cec690d5d68aa54
Comment 7 Eclipse Genie CLA 2017-01-23 05:39:28 EST
New Gerrit change created: https://git.eclipse.org/r/89332
Comment 8 Jessy Mallet CLA 2017-01-23 07:25:43 EST
Validated with Sirius 4.1.3.201701201602
Comment 9 Pierre-Charles David CLA 2017-01-23 11:07:01 EST
Verified by Jessy.
Comment 11 Pierre-Charles David CLA 2017-01-31 03:48:39 EST
Available in Sirius 4.1.3, see https://wiki.eclipse.org/Sirius/4.1.3 for version details.