Bugzilla – Full Text Bug Listing
| Summary: | Validate if the open id migration script always link to an active user | ||
|---|---|---|---|
| Product: | Community | Reporter: | Christopher Guindon <chris.guindon> |
| Component: | Accounts.eclipse.org | Assignee: | Eclipse Web <webdev> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | wayne.beaton, webmaster |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
|
Description
Christopher Guindon
Wayne, can you point me to the code where you create missing users in the PMI? I want to confirm the issue. After fixing a committer account, I am no longer convinced that the issue originate with the PMI. I now believe that the issue might originate with the openid migration script. For completeness: foundationdb_update__process_person This function searches for an existing user based on the name (committer id). If it doesn't find such a user, it creates one. Otherwise, it updates the existing user. It sets the email address to whatever we have in the Foundation DB. Where we break is in the event that the committer ID is changed. When this happens we will create an entirely new user that has the same email address as the original. These duplicate email addresses have caused me trouble in the past. I tend to just delete the extra users when I find them. It occurs to me that we can do marginally better by first checking for the user by id and--if that fails--try and find the user using the email address. If we do find the user by email address, we'd have to change the name; I'm pretty sure that Drupal is okay with this (the name is not a primary key field AFAIK). Changing this to wont fix. The migration script will choose a user with content. If all users do not own any content, it will use the last user that logged in. |