Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 509615

Summary:	[Webkit2] Test_BrowserSuite fails/hangs with tests.
Product:	[Eclipse Project] Platform	Reporter:	Leo Ufimtsev <lufimtse>
Component:	SWT	Assignee:	Leo Ufimtsev <lufimtse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.7
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=497122 https://git.eclipse.org/r/90090 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8002c6f096b6fd4250b49a56c189b223ab656184 https://bugs.eclipse.org/bugs/show_bug.cgi?id=511874
Whiteboard:
Bug Depends on:
Bug Blocks:	441568

Description Leo Ufimtsev

2016-12-21 15:58:05 EST

On webkit2, test_BrowserSuite's test cases have problems.

testBrowser2 fails
testBrowser4 fails
testBrowser5 hangs
testBrowser7 hangs
testBrowser9 fails

These should to be addressed before webkit2 can be used as default backend.

Comment 1 Leo Ufimtsev

2017-01-31 10:29:51 EST

With the implementation of execute/evaluate/browser function (part 1), some jUnits were fixed.

Currently the following are still failing:
testBrowser2
testBrowser5
testBrowser9

I'll investigate.

Comment 2 Eclipse Genie

2017-02-01 11:24:14 EST

New Gerrit change created: https://git.eclipse.org/r/90090

Comment 3 Eclipse Genie

2017-02-01 13:05:09 EST

New Gerrit change created: https://git.eclipse.org/r/90103

Comment 4 Eclipse Genie

2017-02-06 10:37:31 EST

Gerrit change https://git.eclipse.org/r/90090 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8002c6f096b6fd4250b49a56c189b223ab656184

Comment 5 Leo Ufimtsev

2017-02-07 18:06:20 EST

Newly introduced test_execute_and_closeListener() exposed a bug on OS X. closeWindowListener() isn't triggered by window.close().
I submitted bug for that:
Bug 511874 - [OS X] Browser's closeWindowListener not triggered on 'window.close()' javascript. 

This shows up on the SWT build log:
http://download.eclipse.org/eclipse/downloads/drops4/I20170206-2000/testresults/html/org.eclipse.swt.tests_ep47I-unit-win32_win32.win32.x86_8.0.html

Comment 6 Leo Ufimtsev

2017-03-10 15:26:30 EST

(In reply to Leo Ufimtsev from comment #5)
> Newly introduced test_execute_and_closeListener() exposed a bug on OS X.
> closeWindowListener() isn't triggered by window.close().
> I submitted bug for that:
> Bug 511874 - [OS X] Browser's closeWindowListener not triggered on
> 'window.close()' javascript. 
> 
> This shows up on the SWT build log:
> http://download.eclipse.org/eclipse/downloads/drops4/I20170206-2000/
> testresults/html/org.eclipse.swt.tests_ep47I-unit-win32_win32.win32.x86_8.0.
> html

These are fixed. The following remain:
testBrowser2
testBrowser5
testBrowser9

Comment 7 Leo Ufimtsev

2017-03-21 16:56:14 EDT

No more failing browser tests.