Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 509436

Summary: Add required plugins should find the osgi capabilities
Product: [Eclipse Project] PDE Reporter: Olivier Prouvost <olivier.prouvost>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: major    
Priority: P3 CC: dirk.fauth, Lars.Vogel, martin.karpisek, Vikas.Chandra
Version: 4.5   
Target Milestone: 4.7.3   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/87528
Whiteboard:
Bug Depends on:    
Bug Blocks: 510926    
Attachments:
Description Flags
The result of 'validate plugins' buttons none

Description Olivier Prouvost CLA 2016-12-19 07:40:07 EST
Created attachment 265938 [details]
The result of 'validate plugins' buttons

With the Neon version, osgi.capabilities are now used, and for instance the 'osgi.extender' is now provided by the org.eclipse.equinox.ds plugin. 

If we click in the 'validate plugins' button, it is detected as missing. But if we click in 'Add required plugins', it is neither found nor added. 

The add required plugin should do the same search than validate plugins, and add equinox.ds automatically.
Comment 1 Lars Vogel CLA 2016-12-19 11:39:27 EST
Martin, are you interested in working on this for M5?
Comment 2 Lars Vogel CLA 2016-12-19 11:39:27 EST
Martin, are you interested in working on this for M5?
Comment 3 Lars Vogel CLA 2016-12-21 04:06:26 EST
Relevant code for the launch configuration:

AbstractPluginBlock#addRequiredPlugins
Comment 4 Lars Vogel CLA 2016-12-21 04:32:35 EST
For product it is DependencyCalculator#findDependencies
Comment 5 Eclipse Genie CLA 2016-12-21 04:52:55 EST
New Gerrit change created: https://git.eclipse.org/r/87528
Comment 6 Lars Vogel CLA 2016-12-21 04:53:45 EST
(In reply to Eclipse Genie from comment #5)
> New Gerrit change created: https://git.eclipse.org/r/87528

This is only a proof-of-concept and should be reworked to use the correct OSGi API.
Comment 7 Lars Vogel CLA 2017-07-31 10:34:39 EDT
Tip from Dirk Fauth for working with OSGi capacities: http://stackoverflow.com/questions/27946661/what-is-the-right-way-to-query-for-capabilities-in-the-osgi-container
Comment 8 Vikas Chandra CLA 2017-08-22 01:56:58 EDT
Move to 4.7.2
Comment 9 Olivier Prouvost CLA 2017-10-02 08:50:49 EDT
Fixing this bug, would probably avoid to read this :) :  

https://kthoms.wordpress.com/2017/10/02/resolve-nullpointerexception-in-modelserviceimpl-constructor/#comment-6379
Comment 10 Olivier Prouvost CLA 2017-12-11 09:56:54 EST

*** This bug has been marked as a duplicate of bug 522332 ***
Comment 11 Olivier Prouvost CLA 2017-12-11 10:04:33 EST
I closed this bug while the 522332 is more precise. 

There was a mistake in this bug regarding the equinox.ds... Actually the osgi.extender capability is now provided by org.eclipse.felix.scr and not by equinox.ds