| Summary: | Add required plugins should find the osgi capabilities | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Olivier Prouvost <olivier.prouvost> | ||||
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | dirk.fauth, Lars.Vogel, martin.karpisek, Vikas.Chandra | ||||
| Version: | 4.5 | ||||||
| Target Milestone: | 4.7.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| See Also: | https://git.eclipse.org/r/87528 | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 510926 | ||||||
| Attachments: |
|
||||||
Martin, are you interested in working on this for M5? Martin, are you interested in working on this for M5? Relevant code for the launch configuration: AbstractPluginBlock#addRequiredPlugins For product it is DependencyCalculator#findDependencies New Gerrit change created: https://git.eclipse.org/r/87528 (In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/87528 This is only a proof-of-concept and should be reworked to use the correct OSGi API. Tip from Dirk Fauth for working with OSGi capacities: http://stackoverflow.com/questions/27946661/what-is-the-right-way-to-query-for-capabilities-in-the-osgi-container Move to 4.7.2 Fixing this bug, would probably avoid to read this :) : https://kthoms.wordpress.com/2017/10/02/resolve-nullpointerexception-in-modelserviceimpl-constructor/#comment-6379 *** This bug has been marked as a duplicate of bug 522332 *** I closed this bug while the 522332 is more precise. There was a mistake in this bug regarding the equinox.ds... Actually the osgi.extender capability is now provided by org.eclipse.felix.scr and not by equinox.ds |
Created attachment 265938 [details] The result of 'validate plugins' buttons With the Neon version, osgi.capabilities are now used, and for instance the 'osgi.extender' is now provided by the org.eclipse.equinox.ds plugin. If we click in the 'validate plugins' button, it is detected as missing. But if we click in 'Add required plugins', it is neither found nor added. The add required plugin should do the same search than validate plugins, and add equinox.ds automatically.