Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 509303

Summary:	Cannot rebind action on OS X
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Eric Moffatt <emoffatt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	emoffatt, Michael_Rennie
Version:	unspecified
Target Milestone:	14.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Mark Macdonald

2016-12-15 11:39:38 EST

1. Open the keyboard shortcuts panel
2. Filter it to the "Open File…" action
3. Click the Edit keybinding icon (pencil)
4. Type Command + P  (⌘ + P) then hit enter to save it

Problem 1: The binding displays as `^ + P` for me which is not the key I typed. The "^" means Ctrl, not Command.

Possibly related: I've configured OS X to map the left Alt key on my US PC keyboard to Command. So when I'm typing this key binding, I'm actually pressing Left Alt + P to enter ⌘ + P.)


Problem 2: I can't actually trigger the command using the binding I saved. Pressing ⌘ + P brings up the browser Print dialog (on the web), or does nothing (on Electron).

Comment 1 Mark Macdonald

2016-12-15 11:42:54 EST

(In reply to Mark Macdonald from comment #0)

> Possibly related: I've configured OS X to map the left Alt key on my US PC
> keyboard to Command. So when I'm typing this key binding, I'm actually
> pressing Left Alt + P to enter ⌘ + P.)

Ignore this point: I tried the builtin keyboard on my Mac and it has the same problem, so the remapping is irrelevant.

Comment 2 Eric Moffatt

2017-01-04 10:31:41 EST

I've just pushed a commit that should fix this. It fixes a typo in the 'COMMAND' constant in littlelib as well as adopting the correct logic of swapping the COMMAND and CTRL keys when creating the binding on a Mac.