| Summary: | EEXIST errors in console for the prefs.json.lock file | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Remy Suen <remy.suen> |
| Component: | Electron | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | Michael_Rennie, Silenio_Quarti |
| Version: | 13.0 | ||
| Target Milestone: | 15.0 | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
| Whiteboard: | |||
I just ran into this while reviewing https://git.eclipse.org/r/#/c/81197/. It was happening because something that tried reading a pref file threw an exception after opening the file, causing fs to not release the lock. Fixed a adding an option to consider the lock is stale after 5s of use. Writing pref files should not take longer than 5 seconds. https://git.eclipse.org/c/gerrit/orion/org.eclipse.orion.client.git/commit/?id=2a32e45d1835f3a2e540b3c4cfffa89f4ba5755a Just got hit by this again. (In reply to Remy Suen from comment #3) > Just got hit by this again. I only saw one instance of the error message though. And I'm running on Node instead of Electron (unlike what I originally reported in comment 0). |
1. Open Electron from the command line. 2. Open the 'Git' view. 3. See EEXIST errors in the console. These errors are caused by the savePrefs(*) function in lib/controllers/prefs.js. Error: EEXIST: file already exists, open 'C:\Users\Remy\.orion\prefs.json.lock' at Error (native) Error: EEXIST: file already exists, open 'C:\Users\Remy\.orion\prefs.json.lock' at Error (native) Error: EEXIST: file already exists, open 'C:\Users\Remy\.orion\prefs.json.lock' at Error (native) Error: EEXIST: file already exists, open 'C:\Users\Remy\.orion\prefs.json.lock' at Error (native)