Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 508968

Summary:	It should be possible to provide a custom implementation of EditingContextAdapter
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Properties	Assignee:	Pierre-Charles David <pierre-charles.david>
Status:	CLOSED FIXED	QA Contact:	Maxime Porhel <maxime.porhel>
Severity:	enhancement
Priority:	P3	CC:	florian.barbin, maxime.porhel
Version:	4.1.0	Keywords:	triaged
Target Milestone:	4.1.3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/86927 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c1ea05fc2a00427bc131caee60afaf9a8c5aeee5
Whiteboard:
Bug Depends on:
Bug Blocks:	509158

Description Pierre-Charles David

2016-12-09 05:27:50 EST

The EditingContextAdapter interface is the central point which defines how the Sirius and EEF runtimes coordinate to manage the lifecycle of the properties views (once they are created). It allows Sirius to request for the properties views to refresh when "interesting" changes happen, and it allows EEF to ask Sirius to perform model changes corresponding to user actions in the appropriate context from the point of view of Sirius.

The implementation used (TransactionalEditingDomainContextAdapter) is currently hardcoded, but it should be possible for downstream Sirius-based products to override it with their own (based on TransactionalEditingDomainContextAdapter or not) to customize/extend this coordination.

Comment 1 Eclipse Genie

2016-12-12 04:21:47 EST

New Gerrit change created: https://git.eclipse.org/r/86927

Comment 2 Eclipse Genie

2016-12-14 09:37:22 EST

Gerrit change https://git.eclipse.org/r/86927 was merged to [v4.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c1ea05fc2a00427bc131caee60afaf9a8c5aeee5

Comment 3 Pierre-Charles David

2017-01-03 03:54:22 EST

Fixed by c1ea05fc2a00427bc131caee60afaf9a8c5aeee5.

Comment 4 Maxime Porhel

2017-01-17 09:01:09 EST

Validated with Sirius 4.1.3.201701161809

Comment 5 Pierre-Charles David

2017-01-31 03:48:18 EST

Available in Sirius 4.1.3, see https://wiki.eclipse.org/Sirius/4.1.3 for version details.