Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 508950

Summary: ThemeBuilder.js line 181 has unused class='editor_group'
Product: [ECD] Orion Reporter: Carolyn MacLeod <Carolyn_MacLeod>
Component: ClientAssignee: Casey Flynn <caseyflynn>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: unspecified   
Target Milestone: 14.0   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/88115
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=aa8a87530c4e93101fa7366a993f9458f282da1a
Whiteboard:
Bug Depends on: 507788    
Bug Blocks:    

Description Carolyn MacLeod CLA 2016-12-08 16:55:13 EST
ThemeBuilder.js has html on line 181 that has 2 class= assignments.
Only class='themeDisplayEditor' is rendered.

    "<div id='editor' class='themeDisplayEditor' class='editor_group'></div>" +

The class='editor_group' isn't used anywhere except in an editor demo (that has its own html), so it should probably just be deleted.
Comment 1 Michael Rennie CLA 2016-12-12 10:50:30 EST
Assigning to Casey as he is in the process of refactoring / reviving theme stuff.
Comment 2 Eclipse Genie CLA 2017-01-05 14:57:55 EST
New Gerrit change created: https://git.eclipse.org/r/88115
Comment 4 Michael Rennie CLA 2017-01-06 12:07:02 EST
Merged, thanks Casey!