Bug 508736

Comment 1 Alexander Nyßen 2016-12-24 05:31:25 EST

I refactored DotAttributes into an Xtend class that uses an @DotAttribute active annotation to generate the getters and setters. The active annotation is defined by a newly created org.eclipse.gef.dot.generator bundle (which is optionally required by org.eclipse.gef.dot, as its a compile time-dependency; the generated DotAttributes class does not provide the annotations). I further merged DotLanguageSupport into DotAttributes, so the API is now more concise (the duplicate code within the DotJavaValidator could be removed).

There is still room for improvement. Within DotAttributes, validation and parsing could be split apart, and it is dubious whether the setters should implicitly validate (we could leave that to the client). Further, DotAttributes should offer a generic parse and serialize method for all attributes. 

Last, further parts of DotAttributes could be generated by introducing an active annotation on the class level (so the validators, parsers, and serializers, as well as the validate, parse, and serialize methods could be generated from the annotated fields).

Comment 2 Matthias Wienand 2018-06-11 05:01:42 EDT

Since generation of DotAttributes is in-place since Oxygen M5, I resolve this ticket as fixed and set the target milestone accordingly.