Bugzilla – Full Text Bug Listing
| Summary: | Side by side compare waits forever | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | Git | Assignee: | Michael Rennie <Michael_Rennie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Silenio_Quarti |
| Version: | 13.0 | ||
| Target Milestone: | 13.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
on orion.eclipse.org if you open a change in the git view, and toggle it to be a side by side compare, the left hand side never populates. The underlying problem here is that the backing impls for gitFileImpl and fileImpl's read functions differ by one argument, so when the comparator calls: read(file.URL, false, { readIfExists: true }) the options map gets assigned to the extra arg in fileImpl (instead of options) and an incorrect value is returned. So we could either just check for the type of the args in fileImpl, or move the extra arg into the options map (for fileImpl calls)