Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 508550

Summary: Update to the latest version of Electron
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: ElectronAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: remy.suen, Silenio_Quarti, steve_northover
Version: 13.0   
Target Milestone: 13.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Michael Rennie CLA 2016-12-01 12:21:56 EST 
Currently we are using version 1.2.7 which is only available as electron-prebuilt. Their repo mentions the name 'electron-prebuilt' will no longer be published soon, so we will also have to change the dependency to 'electron'. Currently though, the published name 'electron' has no 1.2.7 version, so we can't just switch it now until we update to a newer version.

The latest release of electron (as of this writing) is 1.4.10.

This would also be a good chance to update node-git as well.
Comment 1 Steve Northover CLA 2016-12-01 16:37:57 EST 
Mike, are you going to fight this?  Bogdan, Silenio?
Comment 2 Michael Rennie CLA 2016-12-02 02:11:00 EST 
I'll take it.
Comment 3 Silenio Quarti CLA 2016-12-02 08:55:45 EST 
Mike, I have all the setup ready to compile nodegit for windows,mac,linux. It is a pain. I already compiled nodegit 0.16.0 against electron 1.4.10 and uploaded the binaries to downloads eclipse.org.

The package.json version is changed.
Comment 4 Silenio Quarti CLA 2016-12-02 09:54:57 EST 
After upgrading nodegit to 0.16.0, orion.eclipse.org fails to load it. Error:

Using workspace: /localdata/orion.eclipse.org/serverworkspace
nodegit failed to load. Cannot set property 'PROXY' of undefined
Comment 5 Silenio Quarti CLA 2016-12-02 11:54:59 EST 
Fixed
Comment 6 Michael Rennie CLA 2016-12-05 10:54:25 EST 
We should also stop using 'electron-prebuilt' and switch to just 'electron': 

https://github.com/electron-userland/electron-prebuilt#installation

Since the name 'electron-prebuilt' will be unpublished in a couple of weeks (which will break us).