Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 508137

Summary: Cleanup SiriusFormatDataManagerWithMapping interface
Product: [Modeling] Sirius Reporter: Pierre Guilet <pierre.guilet>
Component: DiagramAssignee: Project Inbox <sirius.diagram-inbox>
Status: CLOSED FIXED QA Contact: Pierre-Charles David <pierre-charles.david>
Severity: normal    
Priority: P3 CC: julien.dupont, laurent.fasani, maxime.porhel, pierre-charles.david
Version: unspecifiedKeywords: triaged
Target Milestone: 5.0.0M7   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/93143
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=804492cd0170136f4c3b2793852cb809d4b19cee
Whiteboard:

Description Pierre Guilet CLA 2016-11-24 11:28:53 EST 
1- When fixing https://bugs.eclipse.org/bugs/show_bug.cgi?id=507616 we added a new interface SiriusFormatDataManagerWithMapping to avoid API break.

The methods of this interface should replace the corresponding methods in SiriusFormatDataManager (getFormatData() and addFormatData()) in Sirius 5.0

The class AbstractSiriusFormatDataManager should be updated accordingly after interface removal and methods update.

2- In the previous context, we did not update the interface method methodorg.eclipse.sirius.diagram.ui.tools.internal.format.FormatDataHelper.getRootFormatData(Map<? extends FormatDataKey, ? extends AbstractFormatData>) accordingly to the changes in the patch to avoid again API break.

The method should be replaced in Sirius 5.0 by the one with the same signature as org.eclipse.sirius.diagram.ui.tools.internal.format.semantic.SiriusFormatDataManagerForSemanticElements.getRootFormatData(Map<SemanticNodeFormatDataKey, Map<String, NodeFormatData>>)

and the same code in the implementation. Then the previous method will call the one put in the helper.
Comment 1 Laurent Fasani CLA 2016-11-28 09:11:08 EST 
It is a technical bugzilla. I am marking it triage.
Comment 2 Eclipse Genie CLA 2017-03-15 13:16:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/93143
Comment 4 Pierre-Charles David CLA 2017-03-20 09:50:56 EDT 
Fixed by 804492cd0170136f4c3b2793852cb809d4b19cee.
Comment 5 Pierre-Charles David CLA 2017-05-17 04:30:34 EDT 
Verified.
Comment 6 Pierre-Charles David CLA 2017-06-29 03:33:18 EDT 
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.