Bug 507922

Description Klaus Christiansen 2016-11-22 01:50:23 EST

Created attachment 265503 [details]
The code cleanup settings I used.

Java Code cleanup sometimes removes comments.
It seams that comments on the same line as an IF (maybe other block statements to?) is removed during code cleanup.
Other times the result is just poorly formatted.

Before:
@Override
public String getTypeName() {
    if (type == null) // No type means that we are the type.
        return NameUtils.upperCaseFirstChar(NameUtils.setVariableCase(getName()));
    return type.getTypeName();
}

After:
@Override
public String getTypeName() {
    if (type == null) {
        return NameUtils.upperCaseFirstChar(NameUtils.setVariableCase(getName()));
    }
    return type.getTypeName();
}



This is an example of poorly formatted code cleanup.
Before:
public void addImport(String imp) {
    if (imp.contains("FormGroup2"))
        System.err.println("addToImport ");
    String imppac = imp.substring(0, imp.lastIndexOf("."));
    if (imppac.equals(getPackageName()))
        return; // No need to add classes in same package
    if (getImports().get(imppac + ".*") != null)
        return; // Whole package already imported

    imports.put(imp, imp);
}

After:
public void addImport(String imp) {
    if (imp.contains("FormGroup2")) {
        System.err.println("addToImport ");
    }
    String imppac = imp.substring(0, imp.lastIndexOf("."));
    if (imppac.equals(getPackageName()))
     {
        return; // No need to add classes in same package
    }
    if (getImports().get(imppac + ".*") != null)
     {
        return; // Whole package already imported
    }
   
    imports.put(imp, imp);
}

Another example of poorly formatted code cleanup.

before:
protected void define(FunctionSymbol sym, boolean doSetScope) {
    if (doSetScope)
        sym.scope = this; // track the scope in each symbol
...
}

After:
protected void define(FunctionSymbol sym, boolean doSetScope) {
    if (doSetScope)
     {
        sym.scope = this; // track the scope in each symbol
    }
...
}