Bugzilla – Full Text Bug Listing
| Summary: | [theme] The UI Themes preferences have been removed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> | ||||||
| Component: | Client | Assignee: | Casey Flynn <caseyflynn> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | caseyflynn, emoffatt, wilford | ||||||
| Version: | 13.0 | ||||||||
| Target Milestone: | 14.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| See Also: |
https://git.eclipse.org/r/87081 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0527b81b2eae2312191afe0debe95285aa7b4322 |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 508950 | ||||||||
| Attachments: |
|
||||||||
|
Description
Michael Rennie
Created attachment 265724 [details]
Patch that demonstrates proposed theme changes (following 'option 1' in the design document)
Created attachment 265758 [details]
Patch contains code required to re-enable dynamically loading container themes.
New Gerrit change created: https://git.eclipse.org/r/86767 New Gerrit change created: https://git.eclipse.org/r/86998 New Gerrit change created: https://git.eclipse.org/r/87081 I opened the CQ for the contribution: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12422 Gerrit change https://git.eclipse.org/r/87081 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0527b81b2eae2312191afe0debe95285aa7b4322 The CQ has been approved and the code is merged. Thank you Casey! Casey, this is *sweet*...kudos++. I'm huge fan of this type of immediate feedback ! I'll be playing around with this today and provide feedback but the first impression in great. (In reply to Eric Moffatt from comment #9) Thanks Eric! If possible steer clear of the Import / Export buttons as they are being removed as part of bug 510006 (they shouldn't be there). Casey, I"m holding off on reporting the significant set of one off glitches (i.e. some dialogs are still blue or a mix between the new theme and lightPage, there are still some buttons that aren't being picked up...). The reason is that this is really our bad; our CSS is currently pretty messy and I suspect that we'll never get a proper theme without normalizing at least some of the CSS (i.e. we'll have to start making changes to the actual DOM structure HTML/JS rather than just CSS changes). I've talked with Mike and are considering our options here, any ideas...;-). (In reply to Eric Moffatt from comment #11) Eric, Can I get the list you have compiled so far? I think it would be a good start to begin documenting the one-off items so we can get a better feel for how much work is involved for normalizing the CSS. I'm on board with modifying HTML/JS, and am happy to help in any way I can. Tracking UI fixes on Bug 510297 (In reply to Casey Flynn from comment #12) I was talking to Robert about this and he had a great idea: Instead of attempting override existing styles, we could introduce css classes for each color available to the user. So we would have something like: .primary-background { background-color: foo } .secondary-background { background-color: bar } In addition to these, we could also add classes: .primary-background-onHover:hover { background-color: foo } We could then go through and remove color settings from the existing css files, and update JS/HTML to include the corresponding color classes. Thoughts? |