Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 507663

Summary:

Validate button for Javadoc location path should be disabled if path is empty

Product:

[Eclipse Project] JDT

Reporter:

Andreas Sewe <sewe>

Component:

Assignee:

Vikas Chandra <Vikas.Chandra>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

daniel_megert, noopur_gupta, Vikas.Chandra

Version:

4.6

Target Milestone:

4.8 M4

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/104904
https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=28c2a2dc71ff5f0390f74e3813351e8207b1a92d

Whiteboard:

Attachments:

Description	Flags
Validating Javadoc Location dialog with less than helpful message	none

Description Andreas Sewe

2016-11-17 05:07:30 EST

Testing the Neon.2 RC1 Java EPP package I encountered the following less-than-optimal user experience:

- Create a Java project
- Open its "Properties"
- Go to "Javadoc Location"
- Without entering a "Javadoc location path" click "Validate"

This shows you a "Location might be invalid" dialog with an explanation that has nothing to do with the problem at hand:=, namely that the "Javadoc location path" has not been filled in yet.

IMHO, it would be best to disable the "Validate" button iff "Javadoc location path" is empty (or contains whitespace only).

Comment 1 Andreas Sewe

2016-11-17 05:18:58 EST

Created attachment 265405 [details]
Validating Javadoc Location dialog with less than helpful message

Comment 2 Eclipse Genie

2017-09-11 12:03:30 EDT

New Gerrit change created: https://git.eclipse.org/r/104904

Comment 3 Vikas Chandra

2017-09-11 12:08:17 EDT

I came across this while working on bug 522122. So I created a patch for this as well.

Comment 4 Vikas Chandra

2017-11-04 04:50:44 EDT

Any feedback on the gerrit patch?

Comment 5 Noopur Gupta

2017-11-07 06:25:01 EST

Please release the change if it looks good as I won't be able to review it right now.

Comment 6 Eclipse Genie

2017-11-13 03:30:12 EST

Gerrit change https://git.eclipse.org/r/104904 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=28c2a2dc71ff5f0390f74e3813351e8207b1a92d

Comment 7 Vikas Chandra

2017-12-07 01:10:39 EST

Verified on
Version: Photon (4.8)
Build id: I20171201-2000