Bugzilla – Full Text Bug Listing
| Summary: | Trim the tab name in the default/generic rules | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Cedric Brun <cedric.brun> | ||||||
| Component: | Properties | Assignee: | Pierre-Charles David <pierre-charles.david> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | laurent.fasani, laurent.redor, pierre-charles.david | ||||||
| Version: | 4.1.0 | Keywords: | triaged | ||||||
| Target Milestone: | 4.1.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/84678 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8b24106ccbd3276dba0670002ff05d0e32b737a2 https://git.eclipse.org/r/86052 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=44c4930ddf158925c6ca1d0534df2a4e96db6064 https://git.eclipse.org/r/86213 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4081d89b04ab71212cfb7c1581c3810d9a2c3755 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Thanks for your detailed enhancement submit. We agree that it would be an interesting improvement. It will be fixed at least in next major release of Sirius (5.0 in Oxygen), and probably fixed in next maintenance release 4.1.2. New Gerrit change created: https://git.eclipse.org/r/84678 Gerrit change https://git.eclipse.org/r/84678 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8b24106ccbd3276dba0670002ff05d0e32b737a2 Still left to do: * Improve the labeling of the preference to make it clear this only applies to the default rule. * Mention the new preference in the release notes and in the documentation (ideally with some screenshots of the preference page, and before/after picture). New Gerrit change created: https://git.eclipse.org/r/86052 Gerrit change https://git.eclipse.org/r/86052 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=44c4930ddf158925c6ca1d0534df2a4e96db6064 Doc completed with 44c4930ddf158925c6ca1d0534df2a4e96db6064. Created attachment 265679 [details]
507180
test scenario 1 - open attached project and vsm - check tab max size in preference/sirius/Sirius properties view/Sirius Tabs - selectnesPackage1 (associated elements are self and contained EClass) => check that the three tabs Main, NewEClass1 and NewEClass1-> New... are correctly displayed according the preferences. scenario is OK for validation but I found two other scenarios with problems scenario2: - change, in preferences, tab max size to 5 - unselect and reselect newPackage1 => ISSUE: the EClass2 tab is not displayed any more scenario 3: - change, in preferences, tab max size to 5 - reopen preference dialog and try to set to 20 => ISSUE: the size field allows only one character so when the user changes to 20 it dos not see the result of his action. I reopen this ticket because of scenario 2. New Gerrit change created: https://git.eclipse.org/r/86213 Gerrit change https://git.eclipse.org/r/86213 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4081d89b04ab71212cfb7c1581c3810d9a2c3755 Re-fixed by 4081d89b04ab71212cfb7c1581c3810d9a2c3755. Available in Sirius 4.1.2 (see https://wiki.eclipse.org/Sirius/4.1.2 for details). |
Created attachment 265234 [details] property-view-with-long-tabname When using an EMF object with a fairly long label provider (here it's a task, the summary being used as the label) then the default rules will lead to a huge tab name leading to a close to unusable property view (see screenshot). That would be nice if the default rules would create an ellipsis when a given size is reached. AFAIK this is only needed for the tab name and should not be applied on the others areas where this label might be used.