Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 507145

Summary: 'Import' and 'Export' buttons styled as hovered even when mouse is not there
Product: [ECD] Orion Reporter: Remy Suen <remy.suen>
Component: ClientAssignee: Casey Flynn <caseyflynn>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: Michael_Rennie, wilford
Version: 12.0   
Target Milestone: 13.0   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/85896
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d9889469802eab13d58aea71609fec3c0d2eb441
Whiteboard:

Description Remy Suen CLA 2016-11-07 06:15:31 EST 
OrionHub

1. Settings > Editor Styles
2. Notice the white 'Import' and 'Export' buttons in the top right hand corner.
3. Click the 'Import' button. Notice that while your mouse is over it it changes colour.
4. A dialog will appear. Move the mouse away and see that it goes back to being white.
5. Now close the dialog by clicking the 'X' button.
6. Notice that the button is back to being black as though your mouse is hovering over it.

You can try the same thing with the 'Export' button in Firefox. In Firefox I get a save dialog so I can move the mouse away and see the bug.

On Chrome the file is just automatically downloaded (this seems a little wrong. Is this intentional?) so you're not given a chance to move the mouse away.
Comment 1 Casey Flynn CLA 2016-11-21 21:12:28 EST 
It appears that the cause of this issue is due to CSS specifying the same style for both hover and focus. This issue can also be recreated by:

1. Pressing the tab key on the Editor Styles window
OR
2. Mousing down on any button in the UI, moving the cursor off of the command button then releasing the mouse button

I will look into the command flow to see if there is a clean way release focus from the Import button after it has been clicked (either before the Import Dialogue is displayed, or after the Import dialogue has been closed).
Comment 2 Eclipse Genie CLA 2016-11-28 15:31:44 EST 
New Gerrit change created: https://git.eclipse.org/r/85896
Comment 4 Michael Rennie CLA 2016-12-02 16:26:42 EST 
Merged, thanks Casey.