Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 507087

Summary:	'Generate Link' in compare editor diff page is useless
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Electron	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	13.0
Target Milestone:	13.0
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/84515 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=98d16ac32688b8055de2f7fd70f7305985d1df91
Whiteboard:

Description Remy Suen

2016-11-05 00:26:09 EDT

Electron 1.2.7

1. Make a change to a file under Git source control.
2. Open the 'Git' page.
3. Expand the diff.
4. Click 'Open the compare page' to open the compare editor in another tab.
5. Click 'Generate Link' in the top right hand corner. It does nothing.

Since Electron runs locally, I feel that the 'Generate Link' button is useless since the link is just going to point to localhost. The command should be hidden if Orion is running on Electron.

Comment 1 Eclipse Genie

2016-11-05 00:32:58 EDT

New Gerrit change created: https://git.eclipse.org/r/84515

Comment 2 Eclipse Genie

2016-11-07 11:17:04 EST

Gerrit change https://git.eclipse.org/r/84515 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=98d16ac32688b8055de2f7fd70f7305985d1df91

Comment 3 Michael Rennie

2016-11-07 11:17:32 EST

Merged, thanks Remy!