Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506816

Summary:	AdaptableSupport and ActivatableSupport should be side-effect free.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF Common	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:	Alexander Nyßen <nyssen>
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	5.0.0 (Oxygen) M3
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-11-01 03:28:42 EDT

Up to now, AdaptableSupport handles the activation/deactivation of adapters when they get registered. We should ensure that AdaptableSupport does not have this side effect, as it may not be a valid default behavior. Instead, we should either handle this within ActivatableSupport or leave it to the client.

Comment 1 Alexander Nyßen

2016-11-01 12:33:50 EDT

I pushed the following changes to origin/master:
    
- Ensured that ActivatableSupport and AdaptableSupport are side-effect free. That is, ActivatableSupport now longer deals with adapters, while AdaptableSupport now longer deals with activation.
- Ensured that all activatable adaptables (AbstractVisualPart, HistoricizingDomain, and InfiniteCanvasViewer)) activate their adapters as needed.

Resolving as fixed in 5.0.0 M3 (will include this in an updated contribution).