Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
As discussed in the PMC we should not enable this by default for the aggregator build but use it for the Gerrit validation. This should catch unintentional introduced compile errors and allow people to use other tools, like IntelliJ ;-) to contribute to the Eclipse project and still get the same validation as we get in Eclipse. Gerrit change https://git.eclipse.org/r/84242 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=299ef8cd7945109266f1a0fe16c388608f850e89 (In reply to Lars Vogel from comment #1) > As discussed in the PMC we should not enable this by default for the > aggregator build but use it for the Gerrit validation. I suspect that this will be picked up by our build as well. The change looks very similar to what the aggregator uses. It is very misleading to say we now use project settings but at the same time disable all warnings. (In reply to Dani Megert from comment #3) > I suspect that this will be picked up by our build as well. The change looks > very similar to what the aggregator uses. The settings is in the "build-individual-bundles" profile, so it's not supposed to affect the aggregator build. > It is very misleading to say we now use project settings but at the same > time disable all warnings. At least, this catches some defects that project has marked as errors. USually, when doing a local build, it's very tricky to review warnings, so just highlighting unacceptable ones (marked as errors) is probably enough and not too much to be actually used. (In reply to Dani Megert from comment #3) > It is very misleading to say we now use project settings but at the same > time disable all warnings. If I do not disable warnings, we end up with 15K warnings. (In reply to Mickael Istria from comment #4) > (In reply to Dani Megert from comment #3) > > I suspect that this will be picked up by our build as well. The change looks > > very similar to what the aggregator uses. > > The settings is in the "build-individual-bundles" profile, so it's not > supposed to affect the aggregator build. Indeed. I didn't look at the full file. > > It is very misleading to say we now use project settings but at the same > > time disable all warnings. > > At least, this catches some defects that project has marked as errors. > USually, when doing a local build, it's very tricky to review warnings, so > just highlighting unacceptable ones (marked as errors) is probably enough > and not too much to be actually used. That's true for projects that have tons of warnings in the IDE, i.e. it's not a pattern that should blindly be applied to all repos. Gerrit change https://git.eclipse.org/r/84282 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=85dfb875d274e4cbcb44d29756e803a8daf0c6b6 New Gerrit change created: https://git.eclipse.org/r/141964 New Gerrit change created: https://git.eclipse.org/r/141965 Gerrit change https://git.eclipse.org/r/141964 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d9e190109343449edc2ffdc6e0d9fc46e0192ece Gerrit change https://git.eclipse.org/r/141965 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=b45ea1b32dab553333618b11c1f0e51610791e77 The changes go reverted including approval from Lars. For details see bug 540419 comment 9. |