| Summary: | Drop support mode should be renamed in the VSM editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Joachim Anlauf <anlauf> | ||||
| Component: | Diagram | Assignee: | Pierre-Charles David <pierre-charles.david> | ||||
| Status: | CLOSED FIXED | QA Contact: | Florian Barbin <florian.barbin> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | florian.barbin, maxime.porhel, pierre-charles.david | ||||
| Version: | 4.1.0 | Keywords: | triaged | ||||
| Target Milestone: | 4.1.2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/85530 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1c41ee8abc5ea1c0cbc47410dc5bf5fc6dfcdd45 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Joachim Anlauf
Hi Joachim, The "Diagram" choice might be miss-named, this option existed before the creation of the Tree and Table dialects in Sirius. It should be renamed into "Representation", indicating that it comes from any opened Sirius editor contrary to "Model Explorer" which means it comes from a view and there is only the selected EObject (without any Sirius graphical data). Step to reproduce: * Import the attached project (contains a small ecore file and an aird with Design (from EcoreTools) viewpoint activated * Open the class diagram * Open the class table * Move the class table editor on the right side of eclipse to have both editors displayed side by side. * Select the "NewEClass2" line and drag it on the diagram * Before dropping you see the "drop enabled" grayed feedback * After dropping the "NewEclass2" class appear on the diagram (note that the EcoreTool class diagram has unsynchronized mapping for EClass element, so they can be in the model but not displayed on the diagram and when they are displayed the user can delete them "from diagram" only). So I rename the issue from: > Not possible to drag from a table or tree representation and drop on a diagram into > Drop support mode should be renamed Nevertheless, it's not yet in the scope of a future release. In EcoreTools the class diagram has a "Diagram" drop support to handle the DnD of EClass elements on the diagram. But as shown by the attached sample it direclty works when dragging an EClass from a table. New Gerrit change created: https://git.eclipse.org/r/85530 Created attachment 265519 [details]
The VSM editor's UI after the rename
Gerrit change https://git.eclipse.org/r/85530 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1c41ee8abc5ea1c0cbc47410dc5bf5fc6dfcdd45 The documentation and labels in the VSM editor have been updated to reflect the fact that it actually works for all types of representation, not just diagrams as the previous wording implied. Verified on Sirius 4.1.2.201612011000. Available in Sirius 4.1.2 (see https://wiki.eclipse.org/Sirius/4.1.2 for details). |