Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506637

Summary:	[GTK][HiDPI] Infinite loop in org.eclipse.swt.graphics.Region.translate()
Product:	[Eclipse Project] Platform	Reporter:	Elfi Heck <eheck>
Component:	SWT	Assignee:	Niraj Modi <niraj.modi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	arunkumar.thondapu, niraj.modi
Version:	4.6	Flags:	arunkumar.thondapu: review+
Target Milestone:	4.6.2
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/84636 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=19cd5066dffe40e7cf12c7c2b1ac006ece7313fd https://git.eclipse.org/r/84713
Whiteboard:
Bug Depends on:
Bug Blocks:	495269

Description Elfi Heck

2016-10-27 12:04:52 EDT

The variant of the Region.translate() method that takes a Point as a parameter calls itself. I assume the intention was to call translateInPixels() instead.

Comment 1 Niraj Modi

2016-10-28 03:37:59 EDT

Will take-care of this in M4.

Comment 2 Eclipse Genie

2016-11-08 02:37:16 EST

New Gerrit change created: https://git.eclipse.org/r/84636

Comment 3 Eclipse Genie

2016-11-08 02:59:01 EST

Gerrit change https://git.eclipse.org/r/84636 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=19cd5066dffe40e7cf12c7c2b1ac006ece7313fd

Comment 4 Eclipse Genie

2016-11-08 02:59:02 EST

Gerrit change https://git.eclipse.org/r/84636 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=19cd5066dffe40e7cf12c7c2b1ac006ece7313fd

Comment 5 Niraj Modi

2016-11-08 03:01:33 EST

(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/84636 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=19cd5066dffe40e7cf12c7c2b1ac006ece7313fd

Fixed the problem and also removed the unnecessary Region#translateInPixels (Point pt) method from GTK code. Resolving now.

Comment 6 Niraj Modi

2016-11-09 01:07:20 EST

Reopening, for back-port to 4.6.2

Comment 7 Eclipse Genie

2016-11-09 01:08:25 EST

New Gerrit change created: https://git.eclipse.org/r/84713

Comment 8 Niraj Modi

2016-11-09 01:13:53 EST

(In reply to Eclipse Genie from comment #7)
> New Gerrit change created: https://git.eclipse.org/r/84713

Issue with Gerrit builds, fix directly submitted to 4.6.2 via below git:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R4_6_maintenance&id=0fca83ddbee0ae49a19efd004711d618eef79bc3