| Summary: | Decorators should not restrict the possibilities to select diagram elements that are beneath | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Steve Monnier <steve.monnier> | ||||
| Component: | Diagram | Assignee: | Project Inbox <sirius.diagram-inbox> | ||||
| Status: | CLOSED FIXED | QA Contact: | Florian Barbin <florian.barbin> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | florian.barbin, jessy.mallet, laurent.fasani, laurent.redor, maxime.porhel, pierre-charles.david | ||||
| Version: | 4.0.0 | Keywords: | triaged | ||||
| Target Milestone: | 5.0.0M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/69310 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c5c182f6b57900ccf80ac2f8999f0a28708ecee https://git.eclipse.org/r/85589 https://git.eclipse.org/r/85588 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=754d152de009382b0ca1ceebe7aa4feeab50920a https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=47ed885a5666d0b8c1e597eee865dc0cfbe0ce53 https://bugs.eclipse.org/bugs/show_bug.cgi?id=527391 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Steve Monnier
Steve, have you sample (decorators, diagram navigation, ...) or does it need specific PermissionAuthority like in org.eclipse.sirius.tests.swtbot.LockedRepresentationContainerTest, org.eclipse.sirius.tests.swtbot.modelexplorer.LockedModelExplorerTest, ...? This problem is only for decorators on diagram element or also on diagram? Gerrit change https://git.eclipse.org/r/69310 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c5c182f6b57900ccf80ac2f8999f0a28708ecee WARNING: This commit in Comment 2 has lead to a regression about tooltip. Tooltip on validation decorator is not displayed any more. Indeed, draw2D tries to find a figure under the mouse from which he will display the tooltip and he can not find it because this commit redefined the org.eclipse.draw2d.Figure.findFigureAt(int, int, TreeSearch) method returning null. Moreover, the new SiriusDecoratorEditPolicy has not be applied on the border node EditPart. This should have been because we could border node on border node. New Gerrit change created: https://git.eclipse.org/r/85589 New Gerrit change created: https://git.eclipse.org/r/85588 Gerrit change https://git.eclipse.org/r/85588 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=754d152de009382b0ca1ceebe7aa4feeab50920a Created attachment 267352 [details]
Validation.zip
Steps to reproduce:
* Import project "Validation" from "Validation.zip"
* Open the diagram "new diag"
* Click on the bottom-right corner of the decoration icon about "navigation to new diag2" on root package
* The selected element must be "EClass1Border"
* Launch the action "Validate diagram" (contextual menu on the diagram)
* Click on each "red cross" decorator and ensure that the selected element is the one under the mouse (and not the "parent" of the decorator)
Gerrit change https://git.eclipse.org/r/85589 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=47ed885a5666d0b8c1e597eee865dc0cfbe0ce53 Validated with Sirius 5.0.0.201705121003 Verified by Jessy. Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details. |