Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506420

Summary: Decorators should not restrict the possibilities to select diagram elements that are beneath
Product: [Modeling] Sirius Reporter: Steve Monnier <steve.monnier>
Component: DiagramAssignee: Project Inbox <sirius.diagram-inbox>
Status: CLOSED FIXED QA Contact: Florian Barbin <florian.barbin>
Severity: normal    
Priority: P3 CC: florian.barbin, jessy.mallet, laurent.fasani, laurent.redor, maxime.porhel, pierre-charles.david
Version: 4.0.0Keywords: triaged
Target Milestone: 5.0.0M7   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/69310
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c5c182f6b57900ccf80ac2f8999f0a28708ecee
https://git.eclipse.org/r/85589
https://git.eclipse.org/r/85588
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=754d152de009382b0ca1ceebe7aa4feeab50920a
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=47ed885a5666d0b8c1e597eee865dc0cfbe0ce53
https://bugs.eclipse.org/bugs/show_bug.cgi?id=527391
Whiteboard:
Attachments:
Description Flags
Validation.zip none

Description Steve Monnier CLA 2016-10-24 05:24:26 EDT
Decorators should not restrict the possibilities to select diagram elements that are beneath. Indeed, it is possible to have a decorator on a node A that is displayed over a node B that is on the border of node A.
Comment 1 Laurent Redor CLA 2016-11-08 04:21:27 EST
Steve, have you sample (decorators, diagram navigation, ...) or does it need specific PermissionAuthority like in org.eclipse.sirius.tests.swtbot.LockedRepresentationContainerTest, org.eclipse.sirius.tests.swtbot.modelexplorer.LockedModelExplorerTest, ...?

This problem is only for decorators on diagram element or also on diagram?
Comment 3 Laurent Fasani CLA 2016-11-21 10:52:01 EST
WARNING: This commit in Comment 2 has lead to a regression about tooltip.

Tooltip on validation decorator is not displayed any more. Indeed, draw2D tries to find a figure under the mouse from which he will display the tooltip and he can not find it because this commit redefined the org.eclipse.draw2d.Figure.findFigureAt(int, int, TreeSearch) method returning null.

Moreover, the new SiriusDecoratorEditPolicy has not be applied on the border node EditPart. This should have been because we could border node on border node.
Comment 4 Eclipse Genie CLA 2016-11-23 10:09:58 EST
New Gerrit change created: https://git.eclipse.org/r/85589
Comment 5 Eclipse Genie CLA 2016-11-23 10:10:01 EST
New Gerrit change created: https://git.eclipse.org/r/85588
Comment 7 Laurent Redor CLA 2017-03-20 07:26:05 EDT
Created attachment 267352 [details]
Validation.zip

Steps to reproduce:
* Import project "Validation" from "Validation.zip"
* Open the diagram "new diag"
* Click on the bottom-right corner of the decoration icon about "navigation to new diag2" on root package
* The selected element must be "EClass1Border"
* Launch the action "Validate diagram" (contextual menu on the diagram)
* Click on each "red cross" decorator and ensure that the selected element is the one under the mouse (and not the "parent" of the decorator)
Comment 9 Jessy Mallet CLA 2017-05-15 10:36:51 EDT
Validated with Sirius 5.0.0.201705121003
Comment 10 Pierre-Charles David CLA 2017-05-17 03:21:35 EDT
Verified by Jessy.
Comment 11 Pierre-Charles David CLA 2017-06-29 03:33:02 EDT
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.