Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506330

Summary:	Adaptable scopes need to be maintained transitively by AdapterInjector.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF Common	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	5.0.0 (Oxygen) M3
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-10-21 07:31:41 EDT

Up to now, entering/switching of adaptable scopes is performed by AdapterInjector (when injecting an adaptable) as well as by AdaptableSupport (within constructor). While this ensures that the scope of the 'direct' adaptable is always activated before member injection, it is not ensured that the scopes of all transitive adaptables is activated correctly.

We should ensure that adaptable scopes are maintained by AdapterInjector only (client code should not have to care). Furthermore, AdapterInjector needs to walk the adaptable-adaptable.bound hierarchy to enter all transitive scopes before injecting members.

Comment 1 Alexander Nyßen

2016-10-21 07:56:01 EDT

It seems, AdaptableScopes.switchTo already switches to scopes transitively, so this is already covered. However, this is not performed in enter() and further, there should be no necessity within client code to enter scopes.

Comment 2 Alexander Nyßen

2016-10-21 08:00:34 EDT

It seems the client code calls are necessary to use adaptable scoping for normal Guice injection (i.e. not adapter injection).

This can only be supported in any case, if member injection is used to inject, and the adaptable reference is established before. As such, the use case does not seem to be valid.

Comment 3 Alexander Nyßen

2016-10-21 10:14:29 EDT

I pushed the following changes to origin/master:

- Ensured AdapterInjector enters and leaves adaptable scopes before and after injecting adapters.
- Ensured AdapterScope enter and leave can not be performed by clients (reduced visibility of API).
- Removed field injection test, which is no valid use case (it had applied adaptable scoping to a non-adapter instance).

We now explicitly limit adaptable scopes to adapters, and this is checked within AdaptableScope. 

Resolving as fixed in 5.0.0 M3.

Comment 4 Alexander Nyßen

2016-10-21 23:10:09 EDT

Reopening, as this still does not seem to be working properly. Within the logo example, the ContentPartPool is not yet properly scoped.

Comment 5 Alexander Nyßen

2016-10-22 05:36:44 EDT

Reworked AdaptableScope and AdapterInjector and thereby resolved the following issues in addition:

- Fixed that adapter injector did not infer injection until adaptable hierarchy was completely built.
- Fixed that adapter injector lost certain bindings due to shadowing by equal keys (in the applicable bindings)
- Ensured that adaptable scopes for an adaptable instance's type share the scoped instances.

Confirmed that the ContentPartPool is now correctly scoped within the Logo example.

Resolving as fixed in 5.0.0 M3.