Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506217

Summary: Delete SubMonitor.step
Product: [Eclipse Project] Equinox Reporter: Stefan Xenos <sxenos>
Component: ComponentsAssignee: Stefan Xenos <sxenos>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, eclipse.sprigogin, jarthana, Lars.Vogel
Version: unspecified   
Target Milestone: Oxygen M4   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/84267
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=35dc5d75234efce06240f8d10e8c1f1b4b26b35b
https://git.eclipse.org/r/84429
https://git.eclipse.org/r/84431
https://git.eclipse.org/r/84432
https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=78330b022d1b150ae0f8e598c6876acf83f609fe
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1353b654d0a7eed0f50b859d59d390ade519ee39
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=f3511f0a38be465923c1d735072f234597af1bff
Whiteboard:
Bug Depends on: 505936    
Bug Blocks:    

Description Stefan Xenos CLA 2016-10-19 11:06:37 EDT
Given the optimizations in bug 505936, SubMonitor.split is now incredibly efficient and doesn't do any memory allocation for most invocations.

Since this was the entire justification for SubMonitor.step, I'd suggest that we delete SubMonitor.step and just use SubMonitor.split everywhere.
Comment 1 Stefan Xenos CLA 2016-10-19 11:09:14 EDT
Step was introduced in bug 500483.
Comment 2 Lars Vogel CLA 2016-10-23 12:03:30 EDT
Fine for me, if Sergey also gives his +1.

As step() is already used in platform UI, PDE and (IIRC) resources, we first need to convert these before deleting the new API.
Comment 3 Sergey Prigogin CLA 2016-10-23 23:24:21 EDT
(In reply to Lars Vogel out-of-office until 21.10.2016 from comment #2)
+1 for deletion.
Comment 4 Eclipse Genie CLA 2016-11-01 00:25:54 EDT
New Gerrit change created: https://git.eclipse.org/r/84267
Comment 5 Eclipse Genie CLA 2016-11-01 09:16:01 EDT
New Gerrit change created: https://git.eclipse.org/r/84276
Comment 7 Dani Megert CLA 2016-11-03 07:15:46 EDT
Please note that using @noreference (or any other API Tools tags) for things that are introduced in the same stream, don't have any effect. API Tools compares against the API baseline only, should be set to R4.6.1 in our current master stream.

I suggest you either open bugs against all affected projects along with a Gerrit change, or attach the Gerrit changes to this bug.
Comment 8 Jay Arthanareeswaran CLA 2016-11-03 12:06:37 EDT
Stefan, could you please confirm that a simple replacement of ".step(" with ".split(" is all that is needed? Please refer to bug 506971 for the relevant change in jdt.core.
Comment 9 Stefan Xenos CLA 2016-11-03 13:18:07 EDT
> could you please confirm that a simple replacement of ".step("
> with ".split(" is all that is needed?

Yes. That's all that's needed.
Comment 10 Stefan Xenos CLA 2016-11-03 13:21:06 EDT
> or attach the Gerrit changes to this bug

Will do.
Comment 11 Eclipse Genie CLA 2016-11-03 13:46:14 EDT
New Gerrit change created: https://git.eclipse.org/r/84429
Comment 12 Eclipse Genie CLA 2016-11-03 14:13:15 EDT
New Gerrit change created: https://git.eclipse.org/r/84431
Comment 13 Eclipse Genie CLA 2016-11-03 14:13:27 EDT
New Gerrit change created: https://git.eclipse.org/r/84432