Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 506082

Summary:	All properties must be disposed into DTreeEditor.dispose()
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Tree	Assignee:	Project Inbox <sirius.tree-inbox>
Status:	CLOSED FIXED	QA Contact:	Laurent Redor <laurent.redor>
Severity:	normal
Priority:	P3	CC:	laurent.redor, maxime.porhel, pierre-charles.david, yann.mortier
Version:	3.1.0	Keywords:	triaged
Target Milestone:	3.1.7
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/84002 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7ced4bd44b5c036f7b1c7fed8627680efbe4d3d4
Whiteboard:
Bug Depends on:	501263, 506083
Bug Blocks:

Description Pierre-Charles David

2016-10-17 09:45:29 EDT

+++ This bug was initially created as a clone of Bug #501263 +++

Version: 3.1.3

DTreeEditor does not dispose all its properties:
 * treeModel
 * AbstractDTreeEditor.session
 * AbstractDTreeEditor.undoRedoActionHandler
 * adapterFactory is disposed into DTreeEditor instead AbstractDTreeEditor
 * etc.

All editors should be reviewed in order to check that all properties are properly disposed and/or set to null.

Comment 1 Pierre-Charles David

2016-10-17 09:45:52 EDT

Clone to report the fix on Sirius 3.1.7.

Comment 2 Eclipse Genie

2016-10-27 04:29:00 EDT

New Gerrit change created: https://git.eclipse.org/r/84002

Comment 3 Eclipse Genie

2016-11-02 08:45:58 EDT

Gerrit change https://git.eclipse.org/r/84002 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7ced4bd44b5c036f7b1c7fed8627680efbe4d3d4

Comment 4 Laurent Redor

2016-11-04 06:10:32 EDT

Validated in Sirius 3.1.7.

Validation with YourKit:
* Run Sirius
* "Connect" YourKit on Sirius
* Open a DTreeEditor
* In YourKit capture a memory snapshot, use Object explorer and validate that for the object DTreeEditor the fields mentioned in description are set (and used memory).
* Close the DTreeEditor
* In YourKit capture another memory snapshot, use Object explorer and validate that for the object DTreeEditor the fields mentioned in description are not visible (set to null or disposed).

Comment 5 Pierre-Charles David

2016-11-04 10:03:21 EDT

Available in Sirius 3.1.7. See https://wiki.eclipse.org/Sirius/3.1.7.