Bugzilla – Full Text Bug Listing
| Summary: | Multi-String attribute are not displayed and can't be edited in Sirius table | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Axel RICHARD <axel.richard> | ||||||||||||||
| Component: | Table | Assignee: | Florian Barbin <florian.barbin> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Pierre Guilet <pierre.guilet> | ||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | P3 | CC: | laurent.redor, maxime.porhel, pierre-charles.david | ||||||||||||||
| Version: | 3.1.0 | Keywords: | triaged | ||||||||||||||
| Target Milestone: | 3.1.7 | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Mac OS X | ||||||||||||||||
| See Also: |
https://git.eclipse.org/r/83532 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=23c6be2da7215b3cf300eac31470b62635f59a5c |
||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 506084, 506085 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 264843 [details]
ODEsign-Test
Some pointers to the relevant code: * org.eclipse.sirius.table.ui.tools.internal.editor.provider.DFeatureColumnEditingSupport.getBestCellEditor(EObject, boolean) is where the table editor decides which CellEditor implementation to use * EMF Edit has some standard code in org.eclipse.emf.edit.ui.provider.PropertyDescriptor.createPropertyEditor(Composite composite) to obtain the appropriate CellEditor for editing a given feature. The fix may be as simple as calling the actual EMF Edit code for the feature associated to the column in this case. Note that Sirius already has some custom logic for handling some cases (e.g. booleans). Maybe (probabaly) in the long term using the normal EMF Edit stuff everywhere would be better, but in the context of a maintenance release we'll want to reduce the risk of impacts to specific scenarios and keep the existing idiosyncrasies for the rest. New Gerrit change created: https://git.eclipse.org/r/83532 Created attachment 264948 [details]
new Metamodel to test multi-valued boolean and int attributes
Created attachment 264949 [details]
New odesign and model to test int and booleans
Created attachment 264983 [details]
new metamodel
Created attachment 264984 [details]
New odesign and model
Gerrit change https://git.eclipse.org/r/83532 was merged to [v3.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=23c6be2da7215b3cf300eac31470b62635f59a5c Fixed by commit 23c6be2da7215b3cf300eac31470b62635f59a5c Available in Sirius 3.1.7. See https://wiki.eclipse.org/Sirius/3.1.7. |
Created attachment 264842 [details] Metamodel-Test I found a bug/lack in Sirius 3.1.6 on multi-valuated Estring attributes. If I create a table representation, this table is not able to display and edit such attribute. You can easily reproduce the bug with the metamodel & viewpoint test associated.