Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 50526

Summary: issues with new code formatter
Product: [Eclipse Project] JDT Reporter: Alvin Thompson <alvin>
Component: CoreAssignee: JDT-Core-Inbox <jdt-core-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 3.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Alvin Thompson CLA 2004-01-23 18:48:37 EST
i like it, but it has some stuff that needs to be addressed. please excuse my
somewhat unintelligible notes:

settings UI issuses:
  white space
    classes
      add word: before comma in *extends*/implements clause
      add word: after comma in *extends*/implements clause
    arrays
      checkbox 'between empty braces' stuck on
  blank lines
    before package declaration: one fewer blank lines than specified
  line wrapping
    default indention for wrapped line
      need way to specify 1 space (not just indent levels)
    line wrapping policy
      (all items) sometimes 'always' doesn't work, even w/ 'force split'

enhancements:
  new line
    before implements/extends/throws keywords
     ('force split' too confusing/doesn't work right)
  line wrapping
    (for methods): option "ending ')' on new line"
    binary expressions
      option 'operator at end of line'

  a way to specify member order (like in IDEA):
    fields
    constructors
    methods
    classes


since formatting options very complex, please include many built-in styles with
descriptions (to be shown in the load dialog and to be edited in the save dialog).
Comment 1 Olivier Thomann CLA 2004-01-26 09:35:02 EST
Could you please open a bug report per problem you find?

1)  a way to specify member order (like in IDEA):
    fields
    constructors
    methods
    classes

This is already done using the Sort members action. No plan to add this in the
code formatter.

2) settings UI issues:
  white space
    classes
      add word: before comma in *extends*/implements clause
      add word: after comma in *extends*/implements clause

These are UI issues. I entered bug 50600.

3) arrays
      checkbox 'between empty braces' stuck on
Would you have a test case for this one, please? And enter a new bug report with
the test case attached to it.

4) blank lines
    before package declaration: one fewer blank lines than specified
I entered bug 50601.

5)line wrapping
    default indention for wrapped line
      need way to specify 1 space (not just indent levels)
I entered bug 50599.

6)    line wrapping policy
      (all items) sometimes 'always' doesn't work, even w/ 'force split'

Please provide examples. A test case is always a good input in a bug report.
Enter a new bug report for this one.

7) new line
    before implements/extends/throws keywords
I entered bug 50603.

8) ('force split' too confusing/doesn't work right)
Please provide examples and open a new bug report.

9) line wrapping
    (for methods): option "ending ')' on new line"
I entered bug 50604.

10) binary expressions
     option 'operator at end of line'
Duplicate of bug 48476.

So could you please provide small test cases where requested and open a specific
bug report for each case. This simplifies the tracking of bugs and allows us to
be sure that we fixed all issues.
Comment 2 Olivier Thomann CLA 2004-04-16 12:44:40 EDT
Remaining issues will be reconsidered post 3.0
Comment 3 Alvin Thompson CLA 2004-04-16 14:01:37 EDT
you da man!
Comment 4 Eclipse Webmaster CLA 2009-08-30 02:35:01 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.