Bug 504657

Comment 1 Matthias Becker 2016-10-06 10:07:52 EDT

How can I find out which icon-file this is?

Comment 2 Tony McCrary 2016-10-26 22:59:21 EDT

Created attachment 265072 [details]
Ganymede Comparison

Are you talking about the java project icon in the explorer view? If so, it's very similar to the original aside from some slight coloration differences.

Comment 3 Matthias Becker 2016-10-28 03:08:16 EDT

(In reply to Markus Keller from comment #0)
> Created attachment 264671 [details]
> Screenshot
> 
> I20161004-1000
> 
> The Java Project icon doesn't work well with existing overlays.
> 
> The blue flap in the front is not tall enough any more. In the selected
> element in the screenshot in the widow on the front, the blue flap is hardly
> visible, since it doesn't extend over the bottom rows of pixels that are
> typically covered by overlays.
> 
> The same problem probably applies to other project icons as well, so these
> should all be fixed in the same way.
> 
> Bug 504629 is tracking problems with the repository overlay.

Markus: I tried to find the icon file but wasn't successful. So can you give me a hint were I can find that?

Comment 4 Dani Megert 2016-10-31 05:24:02 EDT

(In reply to Matthias Becker from comment #3)
> (In reply to Markus Keller from comment #0)
> > Created attachment 264671 [details]
> > Screenshot
> > 
> > I20161004-1000
> > 
> > The Java Project icon doesn't work well with existing overlays.
> > 
> > The blue flap in the front is not tall enough any more. In the selected
> > element in the screenshot in the widow on the front, the blue flap is hardly
> > visible, since it doesn't extend over the bottom rows of pixels that are
> > typically covered by overlays.
> > 
> > The same problem probably applies to other project icons as well, so these
> > should all be fixed in the same way.
> > 
> > Bug 504629 is tracking problems with the repository overlay.
> 
> Markus: I tried to find the icon file but wasn't successful. So can you give
> me a hint were I can find that?

There's no Java project icon. What you see is the "normal" project icon:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/plain/bundles/org.eclipse.ui.ide/icons/full/obj16/prj_obj.png
decorated with a 'J'.

Comment 5 Eclipse Genie 2016-10-31 08:15:59 EDT

New Gerrit change created: https://git.eclipse.org/r/84222

Comment 6 Eclipse Genie 2016-10-31 08:16:23 EDT

New Gerrit change created: https://git.eclipse.org/r/84224

Comment 7 Matthias Becker 2016-10-31 08:17:31 EDT

(In reply to Dani Megert from comment #4)
> There's no Java project icon. What you see is the "normal" project icon:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/plain/bundles/org.
> eclipse.ui.ide/icons/full/obj16/prj_obj.png
> decorated with a 'J'.

Thank you. That was the missing hint.
The offset of the complete graphic inside the icon was wrong. I fixed it. See my two gerrit changes.

Comment 8 Matthias Becker 2016-10-31 08:21:32 EDT

Created attachment 265117 [details]
Comparison of old (GIF) and new corrected (PNG) version of prj_obj icon

Comment 9 Eclipse Genie 2016-10-31 08:46:45 EDT

Gerrit change https://git.eclipse.org/r/84224 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=98075d54cc8dfdee2878106285acb8d516c1ae95

Comment 10 Matthias Becker 2016-11-11 04:35:23 EST

Hey guys,

any progress on that. Can we merge the change?

Comment 11 Eclipse Genie 2016-11-11 05:45:14 EST

Gerrit change https://git.eclipse.org/r/84222 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=47ea2556457bd9cb42a672a44da6b72805b6da80

Comment 12 Lars Vogel 2016-11-11 05:46:05 EST

(In reply to Matthias Becker from comment #10)
> Hey guys,
> 
> any progress on that. Can we merge the change?

+1

Please reopen if there are still remaining issues.