Bugzilla – Full Text Bug Listing
New Gerrit change created: https://git.eclipse.org/r/82604 I think this idea deserves consideration, but will just point out it is a huge change. Many consumers assume if they get the "sdk feature" then they are getting the code equivalent of the "sdk product". In fact, I would wonder if we would need an "sdk feature" at all, if component features are moved to product definition. But, in any case, my only point is that this is something that would have to be very well communicated and documented (such as in migration guide, cross project list, etc.). BTW, it is not clear why org.eclipse.platform.source is included in "product" but not the code counterpart? (There could be a good reason for it, it is just not clear.) Thanks for listening. (In reply to David Williams from comment #2) > I think this idea deserves consideration, but will just point out it is a > huge change. Many consumers assume if they get the "sdk feature" then they > are getting the code equivalent of the "sdk product". > I would wonder if we would need an "sdk feature" at all, if component > features are moved to product definition. I like this idea. This would remove one component from the process without any loss of functionality. Good point. I suggest we move the "included features" to dependencies. This will avoid that customers consume the sdk feature and receive a reduced set. > BTW, it is not clear why org.eclipse.platform.source is included in "product" > but not the code counterpart Surprised me too. (In reply to David Williams from comment #2) > Many consumers assume if they get the "sdk feature" then they > are getting the code equivalent of the "sdk product". After some thing about this, I think this risk to change the sdk feature is to high at the moment. > In fact, I would > wonder if we would need an "sdk feature" at all, if component features are > moved to product definition. Really a great idea, lets go for this approach. As the product is ours, we can change it to consume the referred features directly and remove the usage of the sdk feature. This allow will allow us in the future to use root level features and make our product definition more flexible. Hi Lars, Do you think this bug is required. If not can you close this? Thanks Sravan (In reply to Sravan Kumar Lakkimsetti from comment #6) > Do you think this bug is required. If not can you close this? I think it would add value to our users, but I first want to do some local builds to validate that for example updates still work. Unfortunately local builds take forever so this testing takes some dedicated time. Moving to 4.8 The org.eclipse.sdk branding plug-in is currently included in the org.eclipse.sdk feature which also includes all other features. @Alex Instead of adding another feature with only contains the org.eclipse.sdk feature I suggest to remove the other plug-ins from the org.eclipse.sdk feature. AFAIK the EPP do not use it (as they do not deliver cvs). We could announce this change on cross to get additional feedback. Or do you think we should add another feature? New Gerrit change created: https://git.eclipse.org/r/110721 There are plans for this. Will revisit in 4.10 Moving out of 4.10. Please re triage appropriately Gerrit change https://git.eclipse.org/r/82604 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=9fdd53fcf7ab6d94148df7f93b216992f3173a13 New Gerrit change created: https://git.eclipse.org/r/140981 Gerrit change https://git.eclipse.org/r/140981 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=7c10f221407ee697fcd2579139f267825802b2a4 New Gerrit change created: https://git.eclipse.org/r/140982 Removing target now. Please retriage as necessary If no one objects I plan to change our product to feature based soon. Gerrit change https://git.eclipse.org/r/140982 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=b94a2d411480ba5d8494409b7874cde19806f177 Gerrit change https://git.eclipse.org/r/110721 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=82d40262c5966fe8351ce09cb2b89820d84c16e9 Marking as fixed, we may need to reopen if we identify issues with the build result. Reopening: Lars, please sent a mail to cross-project with explanation of possible side effects for downstream consumers, as per comment 2. If I understand it correctly, every product that included SDK feature need to be updated to include list of removed features. I also assume we should add a note to the release notes for 4.13 with similar content. Also please check if this Gerrit issue is related: https://www.eclipse.org/lists/platform-releng-dev/msg33835.html and if we need to update some test configurations that assumed to see the full SDK by including SDK feature, and now see almost nothing. There is no pack200 file associated with the moved features https://download.eclipse.org/eclipse/downloads/drops4/I20190617-1800/buildlogs/reporeports/reports/pack200data.txt New Gerrit change created: https://git.eclipse.org/r/144309 New Gerrit change created: https://git.eclipse.org/r/144310 Gerrit change https://git.eclipse.org/r/144309 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=f92671ac253504b7d152edba2b942b7b30b11ef6 Gerrit change https://git.eclipse.org/r/144310 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=796e4099a73769fd3d59e2f302386f3402d968e8 (In reply to Andrey Loskutov from comment #22) > Also please check if this Gerrit issue is related: > https://www.eclipse.org/lists/platform-releng-dev/msg33835.html and if we > need to update some test configurations that assumed to see the full SDK by > including SDK feature, and now see almost nothing. Yes, this was related: generated update repository contained less artifacts as expected. I wonder if repo publishing task need to be updated, may be it works with features? Remove target milestone. Whoever plans to push that in the future please be ready to spend some non trivial time on releng and etc. to get it right. Please reopen, if you plan to work on this. |
Currently the eclipse SDK feature includes the features listed below. To make it easier to customize the product and potentially introduce root level features for the SDK I suggest to move these features to the product. <includes id="org.eclipse.cvs" version="0.0.0"/> <includes id="org.eclipse.cvs.source" version="0.0.0"/> <includes id="org.eclipse.help" version="0.0.0"/> <includes id="org.eclipse.help.source" version="0.0.0"/> <includes id="org.eclipse.jdt" version="0.0.0"/> <includes id="org.eclipse.jdt.source" version="0.0.0"/> <includes id="org.eclipse.pde" version="0.0.0"/> <includes id="org.eclipse.pde.source" version="0.0.0"/> <includes id="org.eclipse.platform.source" version="0.0.0"/>