Bugzilla – Full Text Bug Listing
| Summary: | [lsp] Consume socket.io for language server communication | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | Client | Assignee: | Michael Rennie <Michael_Rennie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 13.0 | ||
| Target Milestone: | 13.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 499117 | ||
The latest version is 1.4.8, and the CQ is here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12026 The CQ has been approved, and we are consuming the new version in the LSP branch, as well as in the node.js server (package.json) http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3b44b7d9ed297d1544e133ff5fd07e94c8ea030c I'll leave this open until we get a build to test and verify. The new branch name is: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/log/?h=java-lsp we had to abandon the other branch due to a build problem when branch names have '/' chars in them. Build is working fine. Closing fixed. |
Socket.io provides a bunch of nice features we should be using, like: 1. heartbeat - to make sure if the socket closes or becomes unresponsive we can restart it 2. secure - there is an option when creating the connection {secure: true} that will force wss vs ws (we should be doing this) 3. simple server-side coding 4. message parsing, packing / unpacking built right in