Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 502424

Summary:	[Tooling] Allow creation of connectors between two relay ports and relay port to internal behaviour port
Product:	[Modeling] Papyrus-rt	Reporter:	Young-Soo Roh <ysroh>
Component:	tool	Assignee:	Young-Soo Roh <ysroh>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	charles, papyrus-bugs, peter.cigehn
Version:	0.7.2
Target Milestone:	0.9.0
Hardware:	PC
OS:	Windows NT
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=474244 https://bugs.eclipse.org/bugs/show_bug.cgi?id=486968 https://bugs.eclipse.org/bugs/show_bug.cgi?id=487356 https://git.eclipse.org/r/87437 https://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=efd202200e9fb0486674f75d3cdcbe19e2420e80 https://git.eclipse.org/r/89869 https://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=fcf3cdae347e2d07019bf8c1015b351f63fd375b
Whiteboard:	depends_on_papyrus
Bug Depends on:	493630
Bug Blocks:

Description Young-Soo Roh

2016-09-28 10:01:35 EDT

Currently following connectors cannot be created due to limitation from base Papyrus edit helper advice.

- Relay port <-> Relay port
- Relay port <-> Internal behaviour port.

These connectors should be allowed in Papyrus-RT context.

Comment 1 Charles Rivet

2016-11-10 16:26:52 EST

This is a regression.

Rémi, could you please look at this, comment, and assign?

Comment 2 Peter Cigehn

2016-12-06 11:01:06 EST

I have tested this in the latest Papyrus-RT build, based on the latest Papyrus build, now when the change in Papyrus have been merged.

And indeed it is now possible to crate a connector for these two remaining cases.

There is however a fault in the port compatibility check. For the relay port <-> internal behavior port case it works fine, i.e. the check should be made the ports have the same conjugation.

But for the special case of a pass through connector, i.e. relay port <-> relay port, the compatibility checks is incorrect. The conjugation of the two ports should be opposite, i.e. one is conjugate and the other non-conjugated. Currently the compatibility check (that brings up the dialog that states that the ports are incompatible and ask for confirmation to create a connector anyway) only allows ports with the same conjugation to be connected in this case.

Please see Bug 474244 Comment 7, as well as the discussion in Bug 487356, which is summarized (with attached figures) in Bug 487356 Comment 9.

Comment 3 Eclipse Genie

2016-12-19 14:11:30 EST

New Gerrit change created: https://git.eclipse.org/r/87437

Comment 4 Eclipse Genie

2016-12-22 11:22:01 EST

Gerrit change https://git.eclipse.org/r/87437 was merged to [master].
Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=efd202200e9fb0486674f75d3cdcbe19e2420e80

Comment 5 Peter Cigehn

2016-12-23 10:22:43 EST

I have tested this in the latest Papyrus-RT build and it is now possible to create the two remaining connector types (relay <-> relay and relay <-> internal behavior). I suggest to put this one into resolved/verified fixed whenever the missing unit tests are provided (if it is found that they should be provided as discussed on the Gerrit change).

Comment 6 Eclipse Genie

2017-01-30 10:31:17 EST

New Gerrit change created: https://git.eclipse.org/r/89869

Comment 7 Eclipse Genie

2017-01-30 10:42:25 EST

Gerrit change https://git.eclipse.org/r/89869 was merged to [master].
Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=fcf3cdae347e2d07019bf8c1015b351f63fd375b

Comment 8 Peter Cigehn

2017-01-31 02:19:43 EST

Verified to be fixed in the latest Papyrus-RT build. It is now possible to create a connector for the two remaining cases: relay <-> internal behavior port and relay <-> relay.

Comment 9 Peter Cigehn

2017-01-31 02:19:56 EST

Closing as verified fixed.