Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 502142

Summary:	Pass-in IProgressMonitor to ILayoutAlgorithm#applyLayout()
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF Zest	Assignee:	Matthias Wienand <matthias.wienand>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	1.0.0
Target Milestone:	5.0.0 (Oxygen) M6
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-09-26 06:56:52 EDT

In order to be able to monitor the progress when applying a layout-pass, the method ILayoutAlgorithm#applyLayout() should accept an IProgressMonitor.

Comment 1 Matthias Wienand

2017-02-10 11:01:45 EST

Adding an IProgressMonitor parameter would introduce an org.eclipse.core.runtime dependency to the Layout bundle. However, we could leave the type of the parameter unspecified, so that it is possible to pass-in an IProgressMonitor and use it in a custom ILayoutAlgorithm. Moreover, the ILayoutContext#applyLayout() method should also accept an extra parameter that is passed on to ILayoutAlgorithm#applyLayout().

Comment 2 Matthias Wienand

2017-02-13 11:45:48 EST

I added an extra Object parameter to ILayoutAlgorithm, LayoutContext, and GraphPart. The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 M6.

Comment 3 Alexander Nyßen

2017-05-15 03:00:02 EDT

This has been revised before 5.0.0 M6. Subclasses may extend the layout context to add the respective functionality. Changing resolution to WONTFIX.