Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 501988

Summary: [Project Explorer] "Empty parent packages" filter affect PHP model
Product: z_Archived Reporter: Dawid Pakula <zulus>
Component: PDTAssignee: PHP UI <php.ui-inbox>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: silviya, wywrzal
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 478814    

Description Dawid Pakula CLA 2016-09-22 08:30:42 EDT 
This filter is enabled by default. 

Example problematic structure:
src/
  w3des/
    AppBundle/
      w3desAppBundle.php

src/ is buildpath root and with this filter enabled is empty.
Comment 1 Michal Niewrzal CLA 2016-09-22 08:43:00 EDT 
You want to change logic behind this filter or just disable it by default?
Comment 2 Dawid Pakula CLA 2016-09-22 09:40:32 EDT 
If we stop adding IScriptFolder and ISourceModule via content provider (see my comment in bug 501959), probably most of those will be fixed.

I think PHP Project Explorer content provider should be refactored:
1. Add IMember's under IFile only
2. Add buildpath and include path container item under IProject (do not replace it by IScriptProject)
3. Change icons via label provider on IFile and IDir that are inside build paths / library paths.

For now, because we reuse DLTK Content Provider, wrong elements are added.
Comment 3 Michal Niewrzal CLA 2016-09-22 12:05:18 EDT 
Ok, I will take a look at this.
Comment 4 Michal Niewrzal CLA 2016-10-11 15:24:49 EDT 
Should be fixed by bug 502136
Comment 5 Sylvia Tancheva CLA 2017-05-15 06:27:02 EDT 
Closing