Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 501693

Summary: Add the ReflectiveItemProviderAdapterFactory as a fallback for the new reference widget
Product: [Modeling] Sirius Reporter: Stephane Begaudeau <stephane.begaudeau>
Component: PropertiesAssignee: Stephane Begaudeau <stephane.begaudeau>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: julien.dupont, maxime.porhel, pierre-charles.david
Version: 4.0.0Keywords: triaged
Target Milestone: 4.1.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/81316
https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=7ee72dbb8e181856ebce4ad02272068473d29cbd
Whiteboard: needtest
Attachments:
Description Flags
Reproduction data
none
Screenshot of the bug
none
Screenshot of the fix none

Description Stephane Begaudeau CLA 2016-09-19 06:03:27 EDT 
While using the reference widget with a dynamic model, the EMF Edit part is not generated and as such, we should fallback to the ReflectiveItemProviderAdapterFactory to display the value of the references.
Comment 1 Stephane Begaudeau CLA 2016-09-19 06:05:29 EDT 
Created attachment 264246 [details]
Reproduction data

Open the modeling project and click on the background of the diagram
Comment 2 Stephane Begaudeau CLA 2016-09-19 06:05:51 EDT 
Created attachment 264247 [details]
Screenshot of the bug
Comment 3 Stephane Begaudeau CLA 2016-09-19 06:06:09 EDT 
Created attachment 264248 [details]
Screenshot of the fix
Comment 4 Eclipse Genie CLA 2016-09-19 06:07:19 EDT 
New Gerrit change created: https://git.eclipse.org/r/81316
Comment 5 Maxime Porhel CLA 2016-09-19 08:18:25 EDT 
Stéphane, could you give some steps to indicate how to you the reproduction data and which checks are needed to validate the issue ?
Comment 6 Stephane Begaudeau CLA 2016-09-19 08:32:48 EDT 
> Stephane Begaudeau CLA Friend 2016-09-19 06:05:29 EDT Comment 1
> Created attachment 264246 [details]
> Reproduction data
> Open the modeling project and click on the background of the diagram

Import everything in the workspace, open the only diagram of the only model of the only modeling project and click on the background of the diagram (there is nothing in the diagram anyway) with the Properties view opened. It should look like the screenshot of the fix and not the screenshot of the bug.
Comment 8 Pierre-Charles David CLA 2016-09-23 09:00:32 EDT 
Fixed, but some non-regression test would be nice before we close this.
Comment 9 Pierre-Charles David CLA 2016-10-04 08:46:43 EDT 
Fixed.
Comment 10 Pierre-Charles David CLA 2016-10-18 11:08:19 EDT 
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.