Bugzilla – Full Text Bug Listing
| Summary: | <dialog> no longer in html5.1 | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Carolyn MacLeod <Carolyn_MacLeod> |
| Component: | JS Tools | Assignee: | Curtis Windatt <curtis.windatt.public> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, Michael_Rennie, steve_northover |
| Version: | unspecified | ||
| Target Milestone: | 15.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Carolyn MacLeod
dialog does appear to be widely unsupported. do you have any information on whether it will be dropped for 5.2 and forward? We should likely remove it from our content assist. when we do this we should start a wiki page explaining the changes made and why. There is a doc and comments in the plugin explaining where the information was scraped from. All I have is this: https://w3c.github.io/html/changes.html#changes-fpwd which (as of today) says, "<dialog> element This was removed from HTML 5.1 for lack of implementation, and may be removed from HTML 5.2 if not implemented." If this is easy to remove, just remove it. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=50a992f9202f47e469ab80977990bb43e3ed1fab Fixed in master Do we also have attribute value completions for any of the other removed items at the link in comment 2? <menu type=toolbar> or <input type=datetime> etc? (Note that MDN still has all of these, and their doc probably needs to be updated, but they [seem to try to] put an "experimental" icon/tag on them). https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime (In reply to Carolyn MacLeod from comment #5) > Do we also have attribute value completions for any of the other removed > items at the link in comment 2? <menu type=toolbar> or <input type=datetime> > etc? > (Note that MDN still has all of these, and their doc probably needs to be > updated, but they [seem to try to] put an "experimental" icon/tag on them). > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime No, we only have attr value completions for ARIA attrs. I don't see any further changes we need to make to the HTML tools. (In reply to Curtis Windatt from comment #4) > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/ > ?id=50a992f9202f47e469ab80977990bb43e3ed1fab > Fixed in master Why comment it out rather than remove it (and the unused NLS string)? Theres no value in leaving it there. (In reply to Michael Rennie from comment #7) > Why comment it out rather than remove it (and the unused NLS string)? > > Theres no value in leaving it there. The data was scraped from MDN. If that process is run again it will put back the dialog tag. I moved the comment to the top and removed the defunct NLS. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f93b379fc9d5adf22c02fa985cea9d56219a588a |