Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 500985

Summary:	Unify naming of interaction callback methods.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	5.0.0 (Oxygen) M2
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-09-07 08:36:32 EDT

The different interaction policies (IFXOnClickPolicy, IFXOnDragPolicy, IFXOnHoverPolicy, IFXOnPinchSpreadPolicy, IFXOnRotatePolicy, IFXOnScrollPolicy, and IFXOnTypePolicy) are using different naming schemes for their provided callback methods. The IFXOnDragPolicy, for example, provides press(), drag(), and release() methods, whereas the IFXOnPinchSpreadPolicy provides zoomStarted(), zoom(), and zoomFinished() methods, i.e. present tense vs. past tense. The names should be unified, so that all callback methods' names are in past tense.

Comment 1 Matthias Wienand

2016-09-12 05:08:17 EDT

I unified the names by using present tense so that the method names are shorter. Moreover, the start/end callbacks for gesture interaction have been renamed so that start/end is the prefix for these methods. The only exception is IFXOnTypePolicy, where initialPress() and finalRelease() methods are used. The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 M2.