Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 500684

Summary:	[eslint] turn off some new rules
Product:	[ECD] Orion	Reporter:	Olivier Thomann <Olivier_Thomann>
Component:	JS Tools	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, Michael_Rennie, steve_northover
Version:	12.0
Target Milestone:	13.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Olivier Thomann

2016-09-01 11:21:27 EDT

I will list the rules are that turned off by default.

Comment 1 Olivier Thomann

2016-09-01 11:25:31 EDT

I will turn off:
"no-lone-blocks"
"no-param-reassign"
"no-trailing-spaces"
"quotes"

I can also turn off:
"no-void"
"no-unused-expressions"

Let me know if you see another one that should be turned off.

Comment 2 Olivier Thomann

2016-09-01 12:58:00 EDT

Delivered as commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8f04dfb7fc90cd5f4a7c2ae901d6740a989bae1d.
If you want more rules to be disabled by default, let me know and I will deliver the changes as part of this bug.

Comment 3 Olivier Thomann

2016-09-01 14:20:41 EDT

Michael suggests to keep no-irregular-whitespace and turn off:
no-unused-expressions
no-lone-blocks
no-trailing-spaces
quotes
no-void

Will reopen and revisit the fix.

Comment 4 Olivier Thomann

2016-09-01 15:02:16 EDT

Delivered as commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d8ecea8ecc596119334c902f29219e8baa676d3e