Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 500681

Summary:

Remove the old reference widget

Product:

[Modeling] Sirius

Reporter:

Stephane Begaudeau <stephane.begaudeau>

Component:

Properties

Assignee:

Project Inbox <sirius.properties-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

maxime.porhel, pierre-charles.david

Version:

4.0.0

Keywords:

triaged

Target Milestone:

4.1.0

Hardware:

All

OS:

All

See Also:

Whiteboard:

Attachments:

Description	Flags
VSM which triggers an NPE in the migration code.	none

Description Stephane Begaudeau

2016-09-01 11:03:59 EDT

The time has finally come to remove the first version of the reference widget. The removal will use the following strategy:

- remove the reference widget from the eef.ecore and properties.ecore DSLs
- remove the controller, lifecycle manager, etc
- add a migration participant which will convert the use of the old reference widget

If the reference widget was a multiple one, it will be converted into a list, if it was a single one and it used an onClickExpression, it will be converted to a hyperlink otherwise it will be converted into a label.

Comment 1 Eclipse Genie

2016-09-12 04:35:52 EDT

New Gerrit change created: https://git.eclipse.org/r/80889

Comment 2 Eclipse Genie

2016-09-12 04:41:22 EDT

New Gerrit change created: https://git.eclipse.org/r/80891

Comment 3 Eclipse Genie

2016-09-15 04:00:59 EDT

Gerrit change https://git.eclipse.org/r/80889 was merged to [master].
Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=0961d032fa20db8eb0c69b4819daaa3f19b1746f

Comment 4 Eclipse Genie

2016-09-15 04:12:32 EDT

Gerrit change https://git.eclipse.org/r/80891 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fcc2a66c6fb38f52108a48eb3da4eb8226861c1b

Comment 5 Eclipse Genie

2016-09-19 08:33:04 EDT

New Gerrit change created: https://git.eclipse.org/r/81323

Comment 6 Eclipse Genie

2016-09-20 05:49:53 EDT

Gerrit change https://git.eclipse.org/r/81323 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5fd0327982b91a60e0f430cbb0f0520037d70f7e

Comment 7 Pierre-Charles David

2016-09-20 09:44:52 EDT

Created attachment 264286 [details]
VSM which triggers an NPE in the migration code.

I get an NPE in the migration code when loading the attached VSM:

java.lang.NullPointerException
	at org.eclipse.sirius.ui.properties.internal.migration.ReferenceWidgetMigrationParticipant.handleHyperlinkStyle(ReferenceWidgetMigrationParticipant.java:237)
	at org.eclipse.sirius.ui.properties.internal.migration.ReferenceWidgetMigrationParticipant.handleHyperlink(ReferenceWidgetMigrationParticipant.java:216)
	at org.eclipse.sirius.ui.properties.internal.migration.ReferenceWidgetMigrationParticipant.handleControl(ReferenceWidgetMigrationParticipant.java:163)
	at org.eclipse.sirius.ui.properties.internal.migration.ReferenceWidgetMigrationParticipant.postLoad(ReferenceWidgetMigrationParticipant.java:133)
	at org.eclipse.sirius.business.api.migration.AbstractVSMMigrationParticipant.postLoad(AbstractVSMMigrationParticipant.java:41)
	at org.eclipse.sirius.business.internal.migration.AbstractSiriusMigrationService.postLoad(AbstractSiriusMigrationService.java:179)
	at org.eclipse.sirius.business.internal.migration.description.VSMResourceHandler.postLoad(VSMResourceHandler.java:44)
	at org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.doLoad(XMLResourceImpl.java:266)

Comment 8 Eclipse Genie

2016-09-20 10:54:20 EDT

New Gerrit change created: https://git.eclipse.org/r/81480

Comment 9 Pierre-Charles David

2016-09-20 10:54:52 EDT

(In reply to Eclipse Genie from comment #8)
> New Gerrit change created: https://git.eclipse.org/r/81480

This seems to fix the obvious ones I've hit, but there might be others.

Comment 10 Eclipse Genie

2016-09-20 11:58:11 EDT

Gerrit change https://git.eclipse.org/r/81480 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=47dbd82d947fe8eda98f1a7d9fe215fcb071093e

Comment 11 Pierre-Charles David

2016-11-24 11:20:38 EST

Closing, this was actually done for 4.1, but we forgot to close the bugzilla.

Comment 12 Eclipse Genie

2017-04-06 05:26:10 EDT

New Gerrit change created: https://git.eclipse.org/r/94545

Comment 13 Eclipse Genie

2017-04-13 04:26:51 EDT

Gerrit change https://git.eclipse.org/r/94545 was merged to [v4.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bdacb9fd6965febe4c1e4cf2e0ff03d997562380