Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 500561

Summary: Fix an issue with the converter for the labelFontSize and fontSize
Product: [Modeling] Sirius Reporter: Stephane Begaudeau <stephane.begaudeau>
Component: PropertiesAssignee: Stephane Begaudeau <stephane.begaudeau>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: julien.dupont, maxime.porhel, pierre-charles.david
Version: 4.0.0Keywords: triaged
Target Milestone: 4.1.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/80209
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=75605cbc17cb132c6daa8b516f1787cb29f9a896
Whiteboard:
Attachments:
Description Flags
Sample project to reproduce the bug none

Description Stephane Begaudeau CLA 2016-08-31 04:17:19 EDT 
In EEF both concepts are named with the suffix "Expression"
Comment 1 Stephane Begaudeau CLA 2016-09-01 04:27:00 EDT 
Both concepts should be renamed in Sirius and treated as InterpretedExpression because they already have this behavior (you can use the various interpreters available in those properties).
Comment 2 Eclipse Genie CLA 2016-09-01 08:16:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/80209
Comment 4 Maxime Porhel CLA 2016-09-19 05:54:36 EDT 
Hi Stéphane, could you add a validation scenario/model ?
Comment 5 Pierre-Charles David CLA 2016-09-19 08:40:08 EDT 
Steps to reproduce:
1. Create a VSM with a Properties View Description.
2. Inside a Group, create a widget (for example a Text), and an explicit Style element for it.
3. The style should have "Font Name Expression" and "Font Size Expression" attributes, in yellow background and behaving like an expression field.
4. Configure both expressions to return dynamic values depending on some property of the semantic element, and test that the font and the text size are properly updated at runtime depending on the state of the semantic model.
Comment 6 Julien Dupont CLA 2016-10-03 11:29:49 EDT 
No use case to reproduce problem.
Thanks to add a use case or a link to a use case to reproduce problem.
Waiting, issue is reopened.
Comment 7 Pierre-Charles David CLA 2016-10-06 07:53:48 EDT 
Created attachment 264668 [details]
Sample project to reproduce the bug

Steps to validate:
1. Import the attached project and open it.
2. In the model explorer or in the diagram, select classes A, then B.
3. Note that both the font and the text sizes of the "Name" field in the properties view changes between A and B, consistent with the conditions set in the VSM.
4. Select A, in the properties view rename i into C, and notice how the font and text size are dynamically updated to match the expressions in the VSM.
Comment 8 Pierre-Charles David CLA 2016-10-18 11:07:22 EDT 
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.