Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 500105

Summary: Style customization: improve selection of the style to customize
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: DiagramAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: major    
Priority: P3 CC: esteban.dugueperoux, julien.dupont, pierre-charles.david, steve.monnier, vincent.richard
Version: 2.0.4Keywords: triaged
Target Milestone: 4.0.1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/79591
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ba672386055a90c173080f95cd673b28bc8a58dd
Whiteboard:
Bug Depends on: 465952    
Bug Blocks:    
Attachments:
Description Flags
Use case none

Description Pierre-Charles David CLA 2016-08-23 03:26:08 EDT
+++ This bug was initially created as a clone of Bug #465952 +++

In a style property customization, the "applied on" field opens a popup with every styles of the VSM. As they are identified with the type and the color (e.g. square blue) a lot of entries are alike and it is hard to select the good one.
It would be more user friendly if the mapping container of the style was also presented. It could be either by adding the id of the mapping before the style label, or presenting the view as a tree of mapping with styles as sub-elements.
Comment 1 Pierre-Charles David CLA 2016-08-23 03:26:34 EDT
Cloned to report the improvement in Sirius 4.0.1.
Comment 2 Pierre-Charles David CLA 2016-08-23 05:38:32 EDT
(In reply to Pierre-Charles David from comment #1)
> Cloned to report the improvement in Sirius 4.0.1.

Note that the way this was done on master for Sirius 4.1.0 implies API changes, so the patches will need to be slightly reworked to minimize the impacts on the maintenance branch.
Comment 3 Eclipse Genie CLA 2016-08-24 05:14:08 EDT
New Gerrit change created: https://git.eclipse.org/r/79591
Comment 5 Pierre-Charles David CLA 2016-08-26 08:20:37 EDT
Fixed.
Comment 6 Julien Dupont CLA 2016-08-30 09:22:50 EDT
Step to reproduce:
- Open the VSM bug-500105.odesign 
- unfold stylcustomization/Default/Style Customization/Style customization true/Property Customization (by expression)
- Click select button for field "Applied On"
- Check that all style definition is differentiable (must have path of style in the VSM)
Comment 7 Julien Dupont CLA 2016-08-30 09:23:43 EDT
Created attachment 263847 [details]
Use case
Comment 8 Pierre-Charles David CLA 2016-11-04 10:15:12 EDT
Available in Sirius 4.0.1. See https://wiki.eclipse.org/Sirius/4.0.1.