Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 499895

Summary:	Problem while comparing viewpoints in DAnalysisSessionHelper
Product:	[Modeling] Sirius	Reporter:	Arthur Daussy <arthur.daussy_ssii>
Component:	Core	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:	Pierre-Charles David <pierre-charles.david>
Severity:	minor
Priority:	P3	CC:	maxime.porhel, pierre-charles.david, steve.monnier
Version:	4.0.0	Keywords:	triaged
Target Milestone:	5.0.0M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/81796 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6eaadda344fb5db22f20c0b5e0599b540155add6
Whiteboard:	needtest

Description Arthur Daussy

2016-08-18 06:09:04 EDT

The method getContainer of DAnalysisSessionHelper use == to compare 2 viewpoints. In some case, the given viewpoint could be the one loaded from the ViewPointRegistry (so a different instance than the one loaded in the ResourceSet). To be more robust this method could use EqualityHelper.areEquals(like its done in some other part of Sirius)

Regards,

Arthur

Comment 1 Steve Monnier

2016-08-19 11:42:20 EDT

As discussed with Arthur, the issue was detected using a sample that cannot be shared on a bugzilla. We need to create a new sample based on available metamodel to set this issue as "triaged" and ready to be analyzed.

Comment 2 Eclipse Genie

2016-09-23 10:04:16 EDT

New Gerrit change created: https://git.eclipse.org/r/81796

Comment 3 Eclipse Genie

2017-02-17 03:25:03 EST

Gerrit change https://git.eclipse.org/r/81796 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6eaadda344fb5db22f20c0b5e0599b540155add6

Comment 4 Pierre-Charles David

2017-03-07 05:40:02 EST

The only thing missing before we can close this is an automated test.

Comment 5 Pierre-Charles David

2017-05-02 05:00:39 EDT

Marking as resolved to make it clearer what's left to do for 5.0. This is still marked as "needtest".

Comment 6 Pierre-Charles David

2017-05-22 08:50:39 EDT

Verified by re-inspecting the actual code in 5.0M7, as we don't have a concrete reproduction scenario.

Comment 7 Pierre-Charles David

2017-06-29 03:32:32 EDT

Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.